iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2099713438

   Thinking out loud! The new logic, however bit ugly it is because it gives 
freedom to manipulate the Http2SolrClient directly instead of creating it 
through Builder patter -- _anti-pattern_, to copy the listeners from older 
Http2SolrClient to the new Http2SolrClient is added only because of the custom 
timeouts configuration for replication logic. 
   
   ### Is there any way to avoid recreating the Http2SolrClient?
   
   The default socketTimeout and connectionTimeout for UpdateShardHandler http 
client is 60 secs for both, and for IndexFetcher Recovery client It is 120 and 
60 seconds respectively. Can we deprecate or basically remove the older way of 
setting these timeouts at replication Handler level and use the 
UpdateShardHandler config timeouts i.e. 60 seconds for both socket and 
connection? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to