[jira] (SOLR-17156) BJQParserTest failure

2024-02-20 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156 ] Mikhail Khludnev deleted comment on SOLR-17156: - was (Author: mkhludnev): pushed main with a few debug output into my fork https://github.com/mkhludnev/solr/tree/SOLR-17156-BJQTest-failur

[jira] [Assigned] (SOLR-17134) Bucketed rate limiting

2024-02-20 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-17134: - Assignee: Noble Paul > Bucketed rate limiting > -- > > Key:

Re: [PR] Use a System wide property to enable PRS [solr]

2024-02-20 Thread via GitHub
noblepaul merged PR #2230: URL: https://github.com/apache/solr/pull/2230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] SOLR-17140 - 9x backport [solr]

2024-02-20 Thread via GitHub
gus-asf commented on PR #2284: URL: https://github.com/apache/solr/pull/2284#issuecomment-1953997986 The above tidy/spotless check does not reproduce locally for me. Neither running `gradlew spotlessApply` nor running `gradlew tidy` tasks produce changes. The offending file is not changed i

Re: [PR] SOLR-17140 - 9x backport [solr]

2024-02-20 Thread via GitHub
janhoy commented on PR #2284: URL: https://github.com/apache/solr/pull/2284#issuecomment-1954066093 I cannot reproduce either, strange. Maybe open a new JIRA for that precommit failure and proceed with this one? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Update security.json template in solr-cloud-crd.md to include permission for /admin/info/system path [solr-operator]

2024-02-20 Thread via GitHub
janhoy commented on code in PR #680: URL: https://github.com/apache/solr-operator/pull/680#discussion_r1495760537 ## docs/solr-cloud/solr-cloud-crd.md: ## @@ -1057,7 +1063,7 @@ A few aspects of the default `security.json` configuration warrant a closer look "name": "k8

Re: [PR] SOLR-17140 - 9x backport [solr]

2024-02-20 Thread via GitHub
gus-asf commented on PR #2284: URL: https://github.com/apache/solr/pull/2284#issuecomment-1954162673 > I cannot reproduce either, strange. Maybe open a new JIRA for that precommit failure and proceed with this one? I figured it out @epugh pushed stuff while I was working, and has sinc

Re: [PR] SOLR-15444 Document the SwedishMinimalStemmer [solr]

2024-02-20 Thread via GitHub
janhoy commented on PR #380: URL: https://github.com/apache/solr/pull/380#issuecomment-1954184035 I added a `NOTE` box describing the limitations. In the project where we tried it out we ended up with hundreds of lines with exceptions in an override file to try to tame it. -- This is an

Re: [PR] Remove ingress and node-services during reconcile [solr-operator]

2024-02-20 Thread via GitHub
janhoy commented on PR #674: URL: https://github.com/apache/solr-operator/pull/674#issuecomment-1954190172 Any takers for a review? It works when testing locally :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SOLR-17140) Refactor SolrQueryTimeoutImpl to support other implementations

2024-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818810#comment-17818810 ] ASF subversion and git services commented on SOLR-17140: Commit b

Re: [PR] SOLR-17140 - 9x backport [solr]

2024-02-20 Thread via GitHub
gus-asf merged PR #2284: URL: https://github.com/apache/solr/pull/2284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17138) Support other QueryTimeout criteria

2024-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818811#comment-17818811 ] ASF subversion and git services commented on SOLR-17138: Commit b

[jira] [Created] (SOLR-17168) Netty epoll implementation not included in 8.11.3

2024-02-20 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17168: --- Summary: Netty epoll implementation not included in 8.11.3 Key: SOLR-17168 URL: https://issues.apache.org/jira/browse/SOLR-17168 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-17168) Netty epoll implementation not included in 8.11.3

2024-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818821#comment-17818821 ] Jan Høydahl commented on SOLR-17168: Thanks for reporting this. Are you able to provi

Re: [PR] Update security.json template in solr-cloud-crd.md to include permission for /admin/info/system path [solr-operator]

2024-02-20 Thread via GitHub
dan-niles commented on code in PR #680: URL: https://github.com/apache/solr-operator/pull/680#discussion_r1495895175 ## docs/solr-cloud/solr-cloud-crd.md: ## @@ -1057,7 +1063,7 @@ A few aspects of the default `security.json` configuration warrant a closer look "name":

Re: [PR] Update security.json template in solr-cloud-crd.md to include permission for /admin/info/system path [solr-operator]

2024-02-20 Thread via GitHub
janhoy commented on code in PR #680: URL: https://github.com/apache/solr-operator/pull/680#discussion_r1495910828 ## docs/solr-cloud/solr-cloud-crd.md: ## @@ -1057,7 +1063,7 @@ A few aspects of the default `security.json` configuration warrant a closer look "name": "k8

[jira] [Commented] (SOLR-17168) Netty epoll implementation not included in 8.11.3

2024-02-20 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818832#comment-17818832 ] Colvin Cowie commented on SOLR-17168: - [https://github.com/apache/lucene-solr/pull/26

[jira] [Commented] (SOLR-17168) Netty epoll implementation not included in 8.11.3

2024-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818843#comment-17818843 ] ASF subversion and git services commented on SOLR-17168: Commit 1

[jira] [Resolved] (SOLR-17168) Netty epoll implementation not included in 8.11.3

2024-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17168. Fix Version/s: 8.11.4 Resolution: Fixed Thanks > Netty epoll implementation not included in

[jira] [Assigned] (SOLR-17168) Netty epoll implementation not included in 8.11.3

2024-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-17168: -- Assignee: Jan Høydahl > Netty epoll implementation not included in 8.11.3 > --

[PR] SOLR-17141 branch_9x: Create CpuQueryLimit implementation [solr]

2024-02-20 Thread via GitHub
sigram opened a new pull request, #2287: URL: https://github.com/apache/solr/pull/2287 Backport of SOLR-17141 / PR 2244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-02-20 Thread via GitHub
pvcnt commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1496062478 ## solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java: ## @@ -170,10 +170,9 @@ private List findReplicas( .filter(replica -> replica

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-02-20 Thread via GitHub
pvcnt commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1496072172 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -104,27 +104,35 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] remove unused local variable in SolrIndexSearcher.sortDocSet [solr]

2024-02-20 Thread via GitHub
cpoerschke merged PR #2281: URL: https://github.com/apache/solr/pull/2281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] Improving array list and map init [solr]

2024-02-20 Thread via GitHub
renatoh commented on code in PR #2197: URL: https://github.com/apache/solr/pull/2197#discussion_r1496122396 ## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ## @@ -117,7 +117,7 @@ public class SearchHandler extends RequestHandlerBase private SolrCor

Re: [PR] SOLR-17141 branch_9x: Create CpuQueryLimit implementation [solr]

2024-02-20 Thread via GitHub
sigram merged PR #2287: URL: https://github.com/apache/solr/pull/2287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17141) Create CpuAllowedLimit implementation

2024-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818899#comment-17818899 ] ASF subversion and git services commented on SOLR-17141: Commit a

Re: [PR] SOLR-17150: Create MemQueryLimit implementation [solr]

2024-02-20 Thread via GitHub
sigram commented on code in PR #2251: URL: https://github.com/apache/solr/pull/2251#discussion_r1496141887 ## solr/core/src/test-files/solr/configsets/query-limits/conf/solrconfig.xml: ## @@ -0,0 +1,84 @@ + + + + + + + + ${tests.luceneMatchVersion:LATEST} + + + +${s

[jira] [Resolved] (SOLR-17140) Refactor SolrQueryTimeoutImpl to support other implementations

2024-02-20 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck resolved SOLR-17140. - Fix Version/s: main (10.0) 9.6.0 Resolution: Implemented > Refactor SolrQueryTi

[jira] [Resolved] (SOLR-17141) Create CpuAllowedLimit implementation

2024-02-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-17141. - Resolution: Fixed > Create CpuAllowedLimit implementation > -

Re: [PR] SOLR-17140 - 9x backport [solr]

2024-02-20 Thread via GitHub
epugh commented on PR #2284: URL: https://github.com/apache/solr/pull/2284#issuecomment-1954641768 I am working on unmessing up branch_9x with post tool.. Sigh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] SOLR-17150: Create MemQueryLimit implementation [solr]

2024-02-20 Thread via GitHub
sigram commented on PR #2251: URL: https://github.com/apache/solr/pull/2251#issuecomment-1954645058 I'm going to close this PR and re-create it, I had some other changes in another branch and eventually the merge became too messy... -- This is an automated message from the Apache Git Serv

Re: [PR] SOLR-17150: Create MemQueryLimit implementation [solr]

2024-02-20 Thread via GitHub
sigram closed pull request #2251: SOLR-17150: Create MemQueryLimit implementation URL: https://github.com/apache/solr/pull/2251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (SOLR-17169) Solr restart issue with JWT authentioncation plugin enabled

2024-02-20 Thread jhng (Jira)
jhng created SOLR-17169: --- Summary: Solr restart issue with JWT authentioncation plugin enabled Key: SOLR-17169 URL: https://issues.apache.org/jira/browse/SOLR-17169 Project: Solr Issue Type: Bug

[PR] SOLR-17150: Create MemQueryLimit implementation [solr]

2024-02-20 Thread via GitHub
sigram opened a new pull request, #2288: URL: https://github.com/apache/solr/pull/2288 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] factor out SolrIndexSearcher.populateScoresIfNeeded method [solr]

2024-02-20 Thread via GitHub
cpoerschke merged PR #2280: URL: https://github.com/apache/solr/pull/2280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[jira] [Commented] (SOLR-17156) BJQParserTest failure

2024-02-20 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818920#comment-17818920 ] Mikhail Khludnev commented on SOLR-17156: - staring from Lucene 9.11 it tests will

[jira] [Commented] (SOLR-17156) BJQParserTest failure

2024-02-20 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818927#comment-17818927 ] Mikhail Khludnev commented on SOLR-17156: - https://github.com/apache/solr/pull/22

Re: [PR] SOLR-17156: introducing RandomNoReverseMergePolicyFactory [solr]

2024-02-20 Thread via GitHub
mkhludnev commented on PR #2289: URL: https://github.com/apache/solr/pull/2289#issuecomment-1954738998 It needs to be spread across other block join tests as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-20 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1496266236 ## solr/solrj/src/java/org/apache/solr/client/solrj/embedded/SSLConfigBase.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[jira] [Commented] (SOLR-17170) Support Blocks in Index Sorting

2024-02-20 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818929#comment-17818929 ] Mikhail Khludnev commented on SOLR-17170: - you are welcome > Support Blocks in I

[jira] [Created] (SOLR-17170) Support Blocks in Index Sorting

2024-02-20 Thread Mikhail Khludnev (Jira)
Mikhail Khludnev created SOLR-17170: --- Summary: Support Blocks in Index Sorting Key: SOLR-17170 URL: https://issues.apache.org/jira/browse/SOLR-17170 Project: Solr Issue Type: New Feature

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-20 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1496266003 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1057,188 +806,64 @@ public void waitForComplete() { } } - public static cla

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-20 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1496266548 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientJdkImpl.java: ## @@ -0,0 +1,443 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-20 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1496266918 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClientBase.java: ## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-02-20 Thread via GitHub
jdyer1 commented on PR #2259: URL: https://github.com/apache/solr/pull/2259#issuecomment-1954793953 I am reminded here that we have a **NOCOMMIT** in `solr-tests.policy`. I am worried here that the only way to properly set the `java.net.URLPermission` is to enumerate all possible URL's (wi

Re: [PR] SOLR-17166 cloud.sh can't put solr.xml in zk anymore [solr]

2024-02-20 Thread via GitHub
gus-asf merged PR #2279: URL: https://github.com/apache/solr/pull/2279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17166) SOLR-16975 (no solr.xml in zk) broke cloud.sh, fix

2024-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818931#comment-17818931 ] ASF subversion and git services commented on SOLR-17166: Commit e

Re: [PR] SOLR-17166 cloud.sh can't put solr.xml in zk anymore [solr]

2024-02-20 Thread via GitHub
gus-asf commented on PR #2279: URL: https://github.com/apache/solr/pull/2279#issuecomment-1954812346 > I wonder if some of what cloud.sh does could be delegated to other scripts that get more testing? To make it less brittle? Some things to think about: - It's only intended fo

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-02-20 Thread via GitHub
epugh commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-1954855217 Thank you @dsmiley for reviewing this PR... I'm excited for the work @iamsanjay has been doing, and I do NOT feel comfortable reviewing/merging code in this area ;-) -- This is an autom

Re: [PR] SOLR-17058: Request param to disable distributed stats request at query time [solr]

2024-02-20 Thread via GitHub
weiwang19 commented on PR #2046: URL: https://github.com/apache/solr/pull/2046#issuecomment-1954903332 please let me know if there are any concerns to address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] SOLR-16403: Cluster Singleton to remove inactive Shards [solr]

2024-02-20 Thread via GitHub
BitoAgent commented on PR #1926: URL: https://github.com/apache/solr/pull/1926#issuecomment-1954913579 ## PR Run Status - **AI Based Review:** Successful - **Static Analysis:** Failure - Failed to execute static code analysis using FBinfer. ## PR Analysis - **Main theme:*

Re: [PR] SOLR-17058: Request param to disable distributed stats request at query time [solr]

2024-02-20 Thread via GitHub
mkhludnev commented on code in PR #2046: URL: https://github.com/apache/solr/pull/2046#discussion_r1496418338 ## solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java: ## @@ -263,4 +267,51 @@ private void addDocsRandomly() throws IOException, SolrServerException {

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-02-20 Thread via GitHub
magibney commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-195523 This turned into a bigger change than I'd anticipated, but I really didn't see any other way around it. I found that I had to refactor (for clarity) some method/variable names to be more ex

Re: [PR] SOLR-17058: Request param to disable distributed stats request at query time [solr]

2024-02-20 Thread via GitHub
mkhludnev commented on PR #2046: URL: https://github.com/apache/solr/pull/2046#issuecomment-1955158967 > please let me know if there are any concerns to address. pls check https://github.com/weiwang19/solr/pull/1 -- This is an automated message from the Apache Git Service. To respon

[jira] [Created] (SOLR-17171) DeleteCollectionCmd should specify DELETE_INDEX=true

2024-02-20 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-17171: - Summary: DeleteCollectionCmd should specify DELETE_INDEX=true Key: SOLR-17171 URL: https://issues.apache.org/jira/browse/SOLR-17171 Project: Solr Issue Typ

[jira] [Commented] (SOLR-17171) DeleteCollectionCmd should specify DELETE_INDEX=true

2024-02-20 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819002#comment-17819002 ] Michael Gibney commented on SOLR-17171: --- I've categorized this as a "Bug" since I d

Re: [PR] warn about unused UnifiedSolrHighlighter configuration [solr]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #816: URL: https://github.com/apache/solr/pull/816#issuecomment-1955423418 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16138: Throw when streaming and all cores are down [solr]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #784: URL: https://github.com/apache/solr/pull/784#issuecomment-1955423577 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16086: Fixes for doTestIndexFetchOnLeaderRestart [solr]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #734: URL: https://github.com/apache/solr/pull/734#issuecomment-1955423708 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] Add Github Action to test all affected modules [solr]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #684: URL: https://github.com/apache/solr/pull/684#issuecomment-1955423851 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16162: FilterQuery should implement DocSetProducer [solr]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #814: URL: https://github.com/apache/solr/pull/814#issuecomment-1955423499 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16046: Fix leaked threads in TestLeaderElectionZkExpiry [solr]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #690: URL: https://github.com/apache/solr/pull/690#issuecomment-1955423772 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16109: Updates SolrTestCaseJ4 ABC doc comparators to static [solr]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #755: URL: https://github.com/apache/solr/pull/755#issuecomment-1955423655 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-02-20 Thread via GitHub
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-1955856284 I was thinking about the executor in the Http2SolrClient class. **What is the issue?** 1. Http2SolrClent calls `createHttpClient` to create a Jetty HTTP client. By default, If ex

Re: [PR] SOLR-17058: Request param to disable distributed stats request at query time [solr]

2024-02-20 Thread via GitHub
weiwang19 commented on PR #2046: URL: https://github.com/apache/solr/pull/2046#issuecomment-1955911286 Done with the changes. Thank you so much @mkhludnev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] SOLR-17058: Request param to disable distributed stats request at query time [solr]

2024-02-20 Thread via GitHub
mkhludnev commented on PR #2046: URL: https://github.com/apache/solr/pull/2046#issuecomment-1956035890 @weiwang19 please align the code https://github.com/apache/solr/actions/runs/7984305841/job/21803474034?pr=2046 NB: it would be easy if you [ ] allow pushes from maintainers. At leas

Re: [PR] SOLR-17156: introducing RandomNoReverseMergePolicyFactory [solr]

2024-02-20 Thread via GitHub
mkhludnev commented on PR #2289: URL: https://github.com/apache/solr/pull/2289#issuecomment-1956045699 The scope has blown up. Are there other tests rely on block alignment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and