pvcnt commented on code in PR #2203:
URL: https://github.com/apache/solr/pull/2203#discussion_r1496072172
##########
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##########
@@ -104,27 +104,35 @@ public enum Type {
* support NRT (soft commits) and RTG. Any {@link Type#NRT} replica can
become a leader. A shard
* leader will forward updates to all active {@link Type#NRT} and {@link
Type#TLOG} replicas.
*/
- NRT(true, CollectionAdminParams.NRT_REPLICAS),
+ NRT(true, true, false, CollectionAdminParams.NRT_REPLICAS),
/**
* Writes to transaction log, but not to index, uses replication. Any
{@link Type#TLOG} replica
* can become leader (by first applying all local transaction log
elements). If a replica is of
* type {@link Type#TLOG} but is also the leader, it will behave as a
{@link Type#NRT}. A shard
* leader will forward updates to all active {@link Type#NRT} and {@link
Type#TLOG} replicas.
*/
- TLOG(true, CollectionAdminParams.TLOG_REPLICAS),
+ TLOG(true, true, true, CollectionAdminParams.TLOG_REPLICAS),
/**
* Doesn’t index or writes to transaction log. Just replicates from {@link
Type#NRT} or {@link
* Type#TLOG} replicas. {@link Type#PULL} replicas can’t become shard
leaders (i.e., if there
* are only pull replicas in the collection at some point, updates will
fail same as if there is
* no leaders, queries continue to work), so they don’t even participate
in elections.
*/
- PULL(false, CollectionAdminParams.PULL_REPLICAS);
+ PULL(false, false, false, CollectionAdminParams.PULL_REPLICAS);
public final boolean leaderEligible;
+ public final boolean follower;
+ public final boolean followerSkipCommit;
public final String numReplicasPropertyName;
- Type(boolean leaderEligible, String numReplicasPropertyName) {
+ Type(
+ boolean leaderEligible,
+ boolean follower,
Review Comment:
`follower` might be misnamed, but it designates replica types that receive
forwarded updates from their leader. For example, again with ZERO replicas you
proposed, it would be leader eligible but not a follower.
`followerSkipCommit` flags follower replicas that receive updates but do not
commit them (only apply them to their transaction log).
I do agree we need Javadoc, and maybe some renaming if we can come up with
clearer names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
