magibney commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-1955111123
This turned into a bigger change than I'd anticipated, but I really didn't see any other way around it. I found that I had to refactor (for clarity) some method/variable names to be more explicit about the distinction between tlog and ulog. Both concepts are indeed distinct, and are required for different purposes in different places. `ulog` dir remains the directory that is configured by the `updateLog.dir` param, and is the _parent_ directory of the `tlog` dir. The `tlog` dir is the directory that contains the transaction log files. Specifying `ulog` dir as the parent directory allows consistent behavior for the normal case (where we want the `tlog` dir to be implicitly scoped to the core as a consequence of being a subdirectory within the core `data` dir (normally) or core instance dir), and the special case (where an external shared top-level `ulog` dir is configured, within which directories must be created that are explicitly scoped to their associated core). I opted to track the tlog dirs through the core `DirectoryFactory`, which makes directory deletion safer (can't delete untracked directories) and more flexible (e.g., supporting (or at least not breaking for) hdfs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
