pvcnt commented on code in PR #2203:
URL: https://github.com/apache/solr/pull/2203#discussion_r1496062478
##########
solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java:
##########
@@ -170,10 +170,9 @@ private List<String> findReplicas(
.filter(replica -> replica.isActive(clusterState.getLiveNodes()))
.filter(
replica ->
- !builder.onlyNrt
- || (replica.getType() == Replica.Type.NRT
- || (replica.getType() == Replica.Type.TLOG
- && isShardLeader.test(replica))))
+ !builder.onlyRealTime
+ || (replica.getType().follower &&
!replica.getType().followerSkipCommit)
+ || (replica.getType().leaderEligible &&
isShardLeader.test(replica)))
Review Comment:
The goal is to avoid calling the costly `isShardLeader` predicate if we know
the replica type cannot be a leader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
