renatoh commented on code in PR #2197:
URL: https://github.com/apache/solr/pull/2197#discussion_r1496122396
##########
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##########
@@ -117,7 +117,7 @@ public class SearchHandler extends RequestHandlerBase
private SolrCore core;
protected List<String> getDefaultComponents() {
- ArrayList<String> names = new ArrayList<>(8);
+ ArrayList<String> names = new ArrayList<>(9);
Review Comment:
@epugh thinking about it again, it does not make too much sense to use the
factory method List.of just so that we need to adapt code for dealing with a
read-only list. What I would suggest instead is just initialize the ArrayList
without a size at all. The default size then is applied, which is 10, we do not
really save anything create a list with an initialize size < 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
