[jira] [Created] (SOLR-17254) Complete Major changes and Upgrade Notes in RefGuide for 9.6.0

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17254: --- Summary: Complete Major changes and Upgrade Notes in RefGuide for 9.6.0 Key: SOLR-17254 URL: https://issues.apache.org/jira/browse/SOLR-17254 Project: Solr Issue Type

[jira] [Created] (SOLR-17253) Release wizard suggests wrong minor version for jira

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17253: --- Summary: Release wizard suggests wrong minor version for jira Key: SOLR-17253 URL: https://issues.apache.org/jira/browse/SOLR-17253 Project: Solr Issue Type: Bug

Re: [PR] Release 9.6 - protect the release branch [solr]

2024-04-22 Thread via GitHub
gus-asf merged PR #2418: URL: https://github.com/apache/solr/pull/2418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Created] (SOLR-17252) Invoking nano from the release wizard destroys terminal

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17252: --- Summary: Invoking nano from the release wizard destroys terminal Key: SOLR-17252 URL: https://issues.apache.org/jira/browse/SOLR-17252 Project: Solr Issue Type: Bug

[jira] [Created] (SOLR-17251) Release wizard checklist 3: item 6 - Sanity check the DOAP files unclear

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17251: --- Summary: Release wizard checklist 3: item 6 - Sanity check the DOAP files unclear Key: SOLR-17251 URL: https://issues.apache.org/jira/browse/SOLR-17251 Project: Solr

[jira] [Created] (SOLR-17250) Release wizard needs to set user/email for repo it checks out

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17250: --- Summary: Release wizard needs to set user/email for repo it checks out Key: SOLR-17250 URL: https://issues.apache.org/jira/browse/SOLR-17250 Project: Solr Issue Type:

[jira] [Updated] (SOLR-17250) Release wizard needs to set user/email for repo it checks out

2024-04-22 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17250: Issue Type: Bug (was: Improvement) > Release wizard needs to set user/email for repo it checks out > -

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-22 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1575500892 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -845,6 +852,13 @@ public static class Builder protected Long keyStoreReloadInte

[PR] Release 9.6 - protect the release branch [solr]

2024-04-22 Thread via GitHub
gus-asf opened a new pull request, #2418: URL: https://github.com/apache/solr/pull/2418 This prevents force push to branch_9_6 ( see https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#branchpro ) -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] SOLR-17130: edismax-matchalldocs-optimization [solr]

2024-04-22 Thread via GitHub
dsmiley commented on PR #2218: URL: https://github.com/apache/solr/pull/2218#issuecomment-2071171942 Suggested CHANGES.txt Optimization: * SOLR-17130: Optimized edismax when `*:*` is used (Kevin Risden) -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (SOLR-17249) Lack of clarity in branch protection instructions in releaseWizard

2024-04-22 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839900#comment-17839900 ] Gus Heck commented on SOLR-17249: - Clarification on slack indicates that it is indeed the

[jira] [Commented] (SOLR-17249) Lack of clarity in branch protection instructions in releaseWizard

2024-04-22 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839894#comment-17839894 ] Gus Heck commented on SOLR-17249: - For reference: https://github.com/apache/infrastructur

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #2203: URL: https://github.com/apache/solr/pull/2203#issuecomment-2071145600 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] Improving array list and map init [solr]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #2197: URL: https://github.com/apache/solr/pull/2197#issuecomment-2071145641 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-17099: snitch does not return spurious tags [solr]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #2278: URL: https://github.com/apache/solr/pull/2278#issuecomment-2071145551 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

[jira] [Created] (SOLR-17249) Lack of clarity in branch protection instructions in releaseWizard

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17249: --- Summary: Lack of clarity in branch protection instructions in releaseWizard Key: SOLR-17249 URL: https://issues.apache.org/jira/browse/SOLR-17249 Project: Solr Issue

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

2024-04-22 Thread via GitHub
gus-asf commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-2071000102 So code that does something with that maxScore value could hit null/undefined? That's sort of iffy for back compatibility... On Mon, Apr 22, 2024 at 4:51 PM David Smiley ***@***.***>

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-22 Thread via GitHub
laminelam commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2070981138 Hi @epugh Would you please take a look to this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-22 Thread via GitHub
laminelam opened a new pull request, #2417: URL: https://github.com/apache/solr/pull/2417 https://issues.apache.org/jira/browse/SOLR-17248 Context: https://github.com/apache/solr/pull/1994#discussion_r1535512663 # Description Many CLI tool-related classes current

[jira] [Updated] (SOLR-17248) Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage

2024-04-22 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-17248: -- Description: Many CLI tool-related classes currently duplicate SolrZkClient & _CloudSolrClient_ instantiation,

[jira] [Commented] (SOLR-17246) releaseWizard.py remembers choices despite --dry-run

2024-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839849#comment-17839849 ] Jan Høydahl commented on SOLR-17246: Dry run is only designed to not execute commands

Re: [PR] SOLR-17244 - initial cut at an orientation for prospective release managers [solr]

2024-04-22 Thread via GitHub
janhoy commented on code in PR #2415: URL: https://github.com/apache/solr/pull/2415#discussion_r1575350183 ## dev-docs/releasing.adoc: ## @@ -0,0 +1,52 @@ + += Releasing Solr +:toc: left + +== Motiviated? +So you're of the opinion that there are unreleased features or bugfixes

[jira] [Commented] (SOLR-17244) Create a dev-doc to orient prospective release managers

2024-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839846#comment-17839846 ] Jan Høydahl commented on SOLR-17244: I love it! > Create a dev-doc to orient prospec

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

2024-04-22 Thread via GitHub
dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-2070929291 I think the change is "safe" from a test stability standpoint. There is one change to be mentioned in CHANGES.txt and probably in release notes. If rows=0 then maxScore will no longer

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

2024-04-22 Thread via GitHub
gus-asf commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-2070903192 I guess the question is more a matter of how safe you think this change is... We all know that there are some flaky tests. The test doesn't sound related (being admin/recovery related no

[jira] [Created] (SOLR-17248) Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage

2024-04-22 Thread Lamine (Jira)
Lamine created SOLR-17248: - Summary: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage Key: SOLR-17248 URL: https://issues.apache.org/jira/browse/SOLR-17248 Pr

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

2024-04-22 Thread via GitHub
dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-2070806945 Shall I just merge this for 9.6? I think it's embarrassing we've had this perf issue for so long without it being noticed. match-all-docs is so common, like in ping queries for one.

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2024-04-22 Thread via GitHub
dsmiley commented on code in PR #2313: URL: https://github.com/apache/solr/pull/2313#discussion_r1575096509 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1017,19 +1023,21 @@ public String getBaseURL() { } private static class Async

[jira] [Resolved] (SOLR-17242) HttpJdkSolrClient: Better handling of timeout parameters

2024-04-22 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer resolved SOLR-17242. --- Resolution: Won't Fix > HttpJdkSolrClient: Better handling of timeout parameters > --

[jira] [Updated] (SOLR-17242) HttpJdkSolrClient: Better handling of timeout parameters

2024-04-22 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer updated SOLR-17242: -- Description: *HttpJdkSolrClient* takes timeout values on its Builder, but applies them at the request l

[jira] [Updated] (SOLR-17242) HttpJdkSolrClient: Better handling of timeout parameters

2024-04-22 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer updated SOLR-17242: -- Summary: HttpJdkSolrClient: Better handling of timeout parameters (was: Http2SolrClient/HttpJdkSolrCli

[PR] Fix bug: 'WWW-Authenticate' headers missing in MultiAuthPlugin [solr]

2024-04-22 Thread via GitHub
laminelam opened a new pull request, #2416: URL: https://github.com/apache/solr/pull/2416 https://issues.apache.org/jira/browse/SOLR-17247 # Description MultiAuthPlugin does not return WWW-Authenticate' headers When returning a 401 response a Web application needs to

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-22 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1575042664 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1833,18 +1819,24 @@ private int fetchPackets(FastInputStream fis) throws Exception { byte[]

Re: [PR] Use a System wide property to enable PRS [solr]

2024-04-22 Thread via GitHub
dsmiley commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2070113298 @noblepaul OverseerStatusTest still fails occasionally :-( A number of people have bumped into it and maybe wasted some time trying to figure out what happened. Something has to be done.

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-22 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1575036574 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1878,7 +1870,6 @@ private int fetchPackets(FastInputStream fis) throws Exception { log.

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-22 Thread via GitHub
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-2070093200 Below test failed! ``` ./gradlew :solr:core:test --tests "org.apache.solr.cloud.OverseerStatusTest.test" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC

Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-22 Thread via GitHub
dsmiley commented on PR #2414: URL: https://github.com/apache/solr/pull/2414#issuecomment-2070023265 > If a user wanted to send a request to a particular end-point, why not create their own Http[2]SolrClient. Or better yet, just pull an existing client out of CSC through the getters that C

[jira] [Created] (SOLR-17247) 'WWW-Authenticate' headers missing in MultiAuthPlugin

2024-04-22 Thread Lamine (Jira)
Lamine created SOLR-17247: - Summary: 'WWW-Authenticate' headers missing in MultiAuthPlugin Key: SOLR-17247 URL: https://issues.apache.org/jira/browse/SOLR-17247 Project: Solr Issue Type: Bug Se

[jira] [Resolved] (SOLR-17234) LBHttp2SolrClient does not skip "zombie" endpoints

2024-04-22 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer resolved SOLR-17234. --- Resolution: Fixed > LBHttp2SolrClient does not skip "zombie" endpoints >

[jira] [Commented] (SOLR-17234) LBHttp2SolrClient does not skip "zombie" endpoints

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839750#comment-17839750 ] ASF subversion and git services commented on SOLR-17234: Commit 3

[jira] [Updated] (SOLR-17234) LBHttp2SolrClient does not skip "zombie" endpoints

2024-04-22 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer updated SOLR-17234: -- Fix Version/s: main (10.0) > LBHttp2SolrClient does not skip "zombie" endpoints > -

Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-22 Thread via GitHub
dsmiley commented on code in PR #2414: URL: https://github.com/apache/solr/pull/2414#discussion_r1574973038 ## solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java: ## @@ -31,9 +31,15 @@ import org.apache.solr.common.util.ContentStream; /** - * @since solr 1.3 +

Re: [PR] SOLR-17234: LBHttp2SolrClient does not skip "zombie" endpoints [solr]

2024-04-22 Thread via GitHub
jdyer1 merged PR #2411: URL: https://github.com/apache/solr/pull/2411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Created] (SOLR-17246) releaseWizard.py remembers choices despite --dry-run

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17246: --- Summary: releaseWizard.py remembers choices despite --dry-run Key: SOLR-17246 URL: https://issues.apache.org/jira/browse/SOLR-17246 Project: Solr Issue Type: Improveme

[jira] [Created] (SOLR-17245) Use downloads rather than archive for checking KEYS file in release wizard

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17245: --- Summary: Use downloads rather than archive for checking KEYS file in release wizard Key: SOLR-17245 URL: https://issues.apache.org/jira/browse/SOLR-17245 Project: Solr

[jira] [Created] (SOLR-17244) Create a dev-doc to orient prospective release managers

2024-04-22 Thread Gus Heck (Jira)
Gus Heck created SOLR-17244: --- Summary: Create a dev-doc to orient prospective release managers Key: SOLR-17244 URL: https://issues.apache.org/jira/browse/SOLR-17244 Project: Solr Issue Type: Improv

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2024-04-22 Thread via GitHub
magibney commented on code in PR #2313: URL: https://github.com/apache/solr/pull/2313#discussion_r1574801140 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1278,6 +1287,12 @@ public Builder withMaxConnectionsPerHost(int max) { return

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2024-04-22 Thread via GitHub
magibney commented on code in PR #2313: URL: https://github.com/apache/solr/pull/2313#discussion_r1574789547 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1278,6 +1287,15 @@ public Builder withMaxConnectionsPerHost(int max) { return

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2024-04-22 Thread via GitHub
magibney commented on code in PR #2313: URL: https://github.com/apache/solr/pull/2313#discussion_r1574789547 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1278,6 +1287,15 @@ public Builder withMaxConnectionsPerHost(int max) { return

[jira] [Resolved] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-04-22 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17066. Fix Version/s: 9.5 Assignee: Jason Gerlowski Resolution: Fixed Closing this

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2024-04-22 Thread via GitHub
magibney commented on code in PR #2313: URL: https://github.com/apache/solr/pull/2313#discussion_r1574789547 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1278,6 +1287,15 @@ public Builder withMaxConnectionsPerHost(int max) { return

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839664#comment-17839664 ] ASF subversion and git services commented on SOLR-17066: Commit 8

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2024-04-22 Thread via GitHub
magibney commented on code in PR #2313: URL: https://github.com/apache/solr/pull/2313#discussion_r1574778689 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1048,7 +1056,7 @@ private static class AsyncTracker { int getMaxRequestsQueue

Re: [PR] SOLR-17164: Add 2 arg variant of vectorSimilarity() function [solr]

2024-04-22 Thread via GitHub
iamsanjay closed pull request #2292: SOLR-17164: Add 2 arg variant of vectorSimilarity() function URL: https://github.com/apache/solr/pull/2292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839653#comment-17839653 ] ASF subversion and git services commented on SOLR-17066: Commit e

Re: [PR] SOLR-17066: Deprecate SolrJ "core URLs" in ref-guide (9x) [solr]

2024-04-22 Thread via GitHub
gerlowskija merged PR #2409: URL: https://github.com/apache/solr/pull/2409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17234: LBHttp2SolrClient does not skip "zombie" endpoints [solr]

2024-04-22 Thread via GitHub
gerlowskija commented on code in PR #2411: URL: https://github.com/apache/solr/pull/2411#discussion_r1574717736 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientTest.java: ## @@ -108,8 +108,13 @@ public void testAsyncWithFailures() { } catch (

[jira] [Commented] (SOLR-17234) LBHttp2SolrClient does not skip "zombie" endpoints

2024-04-22 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839647#comment-17839647 ] Jason Gerlowski commented on SOLR-17234: Hey [~jdyer] - I believe I introduced th

Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-22 Thread via GitHub
gerlowskija commented on code in PR #2414: URL: https://github.com/apache/solr/pull/2414#discussion_r1574663893 ## solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java: ## @@ -132,6 +138,10 @@ public String getPath() { return path; } + /** + * The path

Re: [PR] SOLR-17066: Deprecate SolrJ "core URLs" in ref-guide (9x) [solr]

2024-04-22 Thread via GitHub
gerlowskija commented on code in PR #2409: URL: https://github.com/apache/solr/pull/2409#discussion_r1574570834 ## solr/solr-ref-guide/modules/deployment-guide/pages/solrj.adoc: ## @@ -119,13 +119,13 @@ Most `SolrClient` implementations (except for `CloudSolrClient` and `Http2S

Re: [PR] SOLR-17066: Deprecate SolrJ "core URLs" in ref-guide (9x) [solr]

2024-04-22 Thread via GitHub
gerlowskija commented on code in PR #2409: URL: https://github.com/apache/solr/pull/2409#discussion_r1574570834 ## solr/solr-ref-guide/modules/deployment-guide/pages/solrj.adoc: ## @@ -119,13 +119,13 @@ Most `SolrClient` implementations (except for `CloudSolrClient` and `Http2S

Re: [PR] SOLR-17066: Deprecate SolrJ "core URLs" in ref-guide (9x) [solr]

2024-04-22 Thread via GitHub
gerlowskija commented on code in PR #2409: URL: https://github.com/apache/solr/pull/2409#discussion_r1574570195 ## solr/solr-ref-guide/modules/deployment-guide/pages/solrj.adoc: ## @@ -136,7 +136,7 @@ If not an `IllegalArgumentException` will be thrown. Base URLs of Clou

[jira] [Resolved] (SOLR-17126) Cut over System.getProperty to EnvUtils.getProperty

2024-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17126. Resolution: Fixed Yes, this was left open to re-use same Jira number for related changes in 9.6. R

[jira] [Commented] (SOLR-5514) atomic update throws exception if the schema contains uuid fields: Invalid UUID String: 'java.util.UUID:e26c4d56-e98d-41de-9b7f-f63192089670'

2024-04-22 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839571#comment-17839571 ] Mikhail Khludnev commented on SOLR-5514: Hey [~gus] whatsup? Do you have a fresh

Re: [PR] fix: avoid reset of security.json if get fails (#659) [solr-operator]

2024-04-22 Thread via GitHub
jasonkingatconversocial commented on code in PR #660: URL: https://github.com/apache/solr-operator/pull/660#discussion_r1574398165 ## controllers/util/solr_security_util.go: ## @@ -238,7 +238,7 @@ func addHostHeaderToProbe(httpGet *corev1.HTTPGetAction, host string) { func c