[ 
https://issues.apache.org/jira/browse/SOLR-17248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lamine updated SOLR-17248:
--------------------------
    Description: 
Many CLI tool-related classes currently duplicate SolrZkClient & 
_CloudSolrClient_ instantiation, with the same code appearing 12 times across 8 
different classes. It would be beneficial to extract this instantiation and 
reuse the code for easy maintainability

 

  was:
Many CLI tool-related classes currently duplicate SolrZkClient & 
_CloudSolrClient_ instantiation, with the same code appearing 12 times across 8 
different classes. It would be beneficial to extract this instantiation and 
reuse the code for easy maintainability

In lot of CLI "{_}tool{_}" related classes _SolrZkClient_ instantiation is 
duplicated (the code is duplicated 12 times in 8 diff classes). I think we 
should extract the code instantiating the _SolrZkClient_ to a separate class as 
well as considering merging ZK related tool classes.


> Refactor ZK related SolrCli tools to separate SolrZkClient and 
> CloudSolrClient instantiation/usage
> --------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-17248
>                 URL: https://issues.apache.org/jira/browse/SOLR-17248
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Lamine
>            Priority: Minor
>
> Many CLI tool-related classes currently duplicate SolrZkClient & 
> _CloudSolrClient_ instantiation, with the same code appearing 12 times across 
> 8 different classes. It would be beneficial to extract this instantiation and 
> reuse the code for easy maintainability
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to