gus-asf commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-2071000102
So code that does something with that maxScore value could hit null/undefined? That's sort of iffy for back compatibility... On Mon, Apr 22, 2024 at 4:51 PM David Smiley ***@***.***> wrote: > I think the change is "safe" from a test stability standpoint. > > There is one change to be mentioned in CHANGES.txt and probably in release > notes. If rows=0 then maxScore will no longer be returned. The user must > ask for at least one row if the score is desired. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/solr/pull/2221#issuecomment-2070929291>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALF2L3KHFCKC2CFZ6OHG3FTY6VZZXAVCNFSM6AAAAABCJOYDZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZQHEZDSMRZGE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- http://www.needhamsoftware.com (work) https://a.co/d/b2sZLD9 (my fantasy fiction book) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
