gerlowskija commented on code in PR #2414:
URL: https://github.com/apache/solr/pull/2414#discussion_r1574663893
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -132,6 +138,10 @@ public String getPath() {
return path;
}
+ /**
+ * The path of this request following the core or collection (if
applicable). Sometimes called the
Review Comment:
[0] Maybe tweak the wording here to make it a little clearer what value this
method expects for requests that **don't** target a particular core/collection.
Perhaps something like:
> The HTTP path suffix used when sending this request.
>
> Commonly used with {@link #getBasePath()} and {@link #getCollection()} to
assemble the full HTTP path for the request.
>
> For requests targeting a specific core or collection, callers need only
specify those path components that follow the collection name (e.g. "/select"
for the request "/solr/coreName/select"). This is sometimes called the
"handler" path.
>
> For requests that don't target a particular core or collection, callers
should specify any path components that follow "/solr" or "/api" (e.g.
"/admin/info/health" in "/solr/admin/info/health").
Feel free to ignore this advice though - any javadocs here are an
improvement.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -31,9 +31,15 @@
import org.apache.solr.common.util.ContentStream;
/**
- * @since solr 1.3
+ * Base class for a SolrJ request to Solr. A common way to send it is via
{@link
+ * #process(SolrClient)}.
+ *
+ * <p>Not thread-safe; in fact {@link
org.apache.solr.client.solrj.impl.LBSolrClient} will
Review Comment:
😬
Not an issue for this PR, but man, this is kindof scary to see written out.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -86,6 +87,16 @@
import org.slf4j.LoggerFactory;
import org.slf4j.MDC;
+/**
+ * SolrCloud-aware implementation of {@link SolrClient}. It's able to route
requests to the ideal
+ * node, knowing where the collection and it's replicas are hosted. It will
even break up an update
+ * request with a batch of documents knowing where each document goes
(assuming there is more than
+ * one shard). It will do some retries and fail-over to alternative replicas
in an attempt to proces
Review Comment:
[0] Typo: "proces" -> "process"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
