laminelam opened a new pull request, #2417: URL: https://github.com/apache/solr/pull/2417
https://issues.apache.org/jira/browse/SOLR-17248 Context: https://github.com/apache/solr/pull/1994#discussion_r1535512663 # Description Many CLI tool-related classes currently duplicate SolrZkClient & CloudSolrClient instantiation, with the same code appearing 12 times across 8 different classes. It would be beneficial to extract this instantiation and reuse the code for easy maintainability # Solution Extract duplicate code into _SolrCLI_ class. Call it from other places. This PR adds as well a SolrClassLoader option to CloudHttp2SolrClient Builder # Tests No need to more test cases as this code refactoring. Existing tests all passed # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
