[jira] [Commented] (SOLR-16126) Allow FiltersQParser (`{!filters param=[...]}`) to tolerate empty `param` args

2022-04-22 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526734#comment-17526734 ] Michael Gibney commented on SOLR-16126: --- Thanks for weighing in. That explanation m

[GitHub] [solr] magibney commented on pull request #815: SOLR-13044: fix searcher/core close sequence

2022-04-22 Thread GitBox
magibney commented on PR #815: URL: https://github.com/apache/solr/pull/815#issuecomment-1107057740 Yeah agreed. I can't pretend to really understand what's going on here just yet (hence opening #818 with the title "review [...]" as opposed to "revert [...]"). I think it definitely warrants

[GitHub] [solr] dsmiley commented on pull request #815: SOLR-13044: fix searcher/core close sequence

2022-04-22 Thread GitBox
dsmiley commented on PR #815: URL: https://github.com/apache/solr/pull/815#issuecomment-1106880696 It's possible that isn't an issue; I suspect the searcher and/or request being open after the core close will keep the core increment one higher and thus not _actually_ closed until the search

[jira] [Commented] (SOLR-16126) Allow FiltersQParser (`{!filters param=[...]}`) to tolerate empty `param` args

2022-04-22 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526687#comment-17526687 ] Mikhail Khludnev commented on SOLR-16126: - Hi, Michael. Sorry for being late. Pr

[jira] [Updated] (SOLR-16145) Overseer rejoinOverseerElection NPE

2022-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16145: Affects Version/s: 7.7.2 > Overseer rejoinOverseerElection NPE > --

[jira] [Commented] (SOLR-13044) IndexFetcher.openNewSearcherAndUpdateCommitPoint can throw NPE on null SolrCore

2022-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526672#comment-17526672 ] ASF subversion and git services commented on SOLR-13044: Commit 7

[GitHub] [solr] dsmiley merged pull request #815: SOLR-13044: fix searcher/core close sequence

2022-04-22 Thread GitBox
dsmiley merged PR #815: URL: https://github.com/apache/solr/pull/815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] magibney opened a new pull request, #818: SOLR-16163: Review unintended try-with-resources closing-order modifications

2022-04-22 Thread GitBox
magibney opened a new pull request, #818: URL: https://github.com/apache/solr/pull/818 See: [SOLR-16163](https://issues.apache.org/jira/browse/SOLR-16163) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Created] (SOLR-16163) Review unintended try-with-resources closing-order modifications

2022-04-22 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-16163: - Summary: Review unintended try-with-resources closing-order modifications Key: SOLR-16163 URL: https://issues.apache.org/jira/browse/SOLR-16163 Project: Solr

[jira] [Commented] (SOLR-16162) FilterQuery (`filter([some_query])`) should implement DocSetProducer

2022-04-22 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526606#comment-17526606 ] Michael Gibney commented on SOLR-16162: --- Sure!: currently FilterQuery consults the

[jira] [Commented] (SOLR-16162) FilterQuery (`filter([some_query])`) should implement DocSetProducer

2022-04-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526577#comment-17526577 ] Mike Drob commented on SOLR-16162: -- Can you give an example of where the full clone take

[GitHub] [solr] magibney commented on pull request #815: SOLR-13044: fix searcher/core close sequence

2022-04-22 Thread GitBox
magibney commented on PR #815: URL: https://github.com/apache/solr/pull/815#issuecomment-1106641151 Much of this commit is fine I think, but there's definitely some changes that introduce this kind of reordering: 1dba8a6f6b1c06fddb374a3b81ceeff537256848 -- This is an automated message fro

[GitHub] [solr] magibney commented on pull request #815: SOLR-13044: fix searcher/core close sequence

2022-04-22 Thread GitBox
magibney commented on PR #815: URL: https://github.com/apache/solr/pull/815#issuecomment-1106630764 I became curious about this, since this kind of quasi-reproducible resource-leak classMethod error is a major source of flakiness in tests, and this close/decref reordering on converting to t

[GitHub] [solr] cpoerschke opened a new pull request, #817: solr-ref-guide: expand 'eval' streaming expression example; fix a few typos;

2022-04-22 Thread GitBox
cpoerschke opened a new pull request, #817: URL: https://github.com/apache/solr/pull/817 No JIRA ticket as yet, and perhaps not needed either? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] cpoerschke opened a new pull request, #816: warn about unused UnifiedSolrHighlighter configuration

2022-04-22 Thread GitBox
cpoerschke opened a new pull request, #816: URL: https://github.com/apache/solr/pull/816 No JIRA issue as yet but would create one if this seem useful. The default config has a comment ``` ``` i.e. https://github.com/apache/solr/blob/branch_9_0/solr/server/solr/co

[jira] [Resolved] (SOLR-16117) Do not publish an empty solr-server.jar to maven

2022-04-22 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16117. --- Resolution: Fixed > Do not publish an empty solr-server.jar to maven > --

[jira] [Resolved] (SOLR-16157) Improve jar de-duplication between server/lib(/ext) and WEB-INF/lib

2022-04-22 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16157. --- Resolution: Fixed > Improve jar de-duplication between server/lib(/ext) and WEB-INF/lib > ---

[jira] [Commented] (SOLR-16117) Do not publish an empty solr-server.jar to maven

2022-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526482#comment-17526482 ] ASF subversion and git services commented on SOLR-16117: Commit 0

[jira] [Commented] (SOLR-16157) Improve jar de-duplication between server/lib(/ext) and WEB-INF/lib

2022-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526481#comment-17526481 ] ASF subversion and git services commented on SOLR-16157: Commit 0

[jira] [Commented] (SOLR-16157) Improve jar de-duplication between server/lib(/ext) and WEB-INF/lib

2022-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526476#comment-17526476 ] ASF subversion and git services commented on SOLR-16157: Commit 2

[jira] [Commented] (SOLR-16117) Do not publish an empty solr-server.jar to maven

2022-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526477#comment-17526477 ] ASF subversion and git services commented on SOLR-16117: Commit 2

[jira] [Commented] (SOLR-16157) Improve jar de-duplication between server/lib(/ext) and WEB-INF/lib

2022-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526471#comment-17526471 ] ASF subversion and git services commented on SOLR-16157: Commit 6

[jira] [Commented] (SOLR-16117) Do not publish an empty solr-server.jar to maven

2022-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526472#comment-17526472 ] ASF subversion and git services commented on SOLR-16117: Commit 6

[GitHub] [solr] HoustonPutman merged pull request #808: SOLR-16157, SOLR-16117: Fix maven release artifacts

2022-04-22 Thread GitBox
HoustonPutman merged PR #808: URL: https://github.com/apache/solr/pull/808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach