[
https://issues.apache.org/jira/browse/SOLR-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526687#comment-17526687
]
Mikhail Khludnev commented on SOLR-16126:
-----------------------------------------
Hi, Michael.
Sorry for being late. Probably (I'm speculating as a person who wrote it) the
reason is the reasonable strictness avoiding trappy typo tolerance like in
classic https://github.com/rmuir/booleanparser. Think about {{q=\{!filter
param=$fq}&fp=easter:egg}}, probably at 3 AM debug session you prefer to get an
explicit error rather than silent swallowing.
That's it. It's just an explanation, please don't consider it as a vote/opinion
for rollback.
> Allow FiltersQParser (`{!filters param=[...]}`) to tolerate empty `param` args
> ------------------------------------------------------------------------------
>
> Key: SOLR-16126
> URL: https://issues.apache.org/jira/browse/SOLR-16126
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: query parsers
> Affects Versions: main (10.0)
> Reporter: Michael Gibney
> Assignee: Michael Gibney
> Priority: Minor
> Fix For: 9.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> One common use case for FiltersQParser is to bundle filters and main query,
> e.g. for passing a single-query domain definition to functions, or for
> finer-grained control over how logical filters are bundled together.
> Consider the first use case: `\{!filters param=$q param=$fq\}`
> FiltersQParser currently strictly enforces that the referred params must be
> present and non-empty, and fails hard (throws a {{SyntaxError}}) if this is
> not the case.
> This issue proposes to relax this enforcement, because:
> # There are legitimate, common use cases for which this requirement is simply
> an inconvenience (albeit easily worked around by adding a "dummy"
> {{fq=\*:\*}}), and
> # It's unclear what practical purpose is served by by the current strict
> enforcement of non-empty params.
> The proposal is to have e.g. `\{!filters param=$fq\}`, in the absence of any
> non-empty {{fq}} param, be equivalent to {{\*:\*}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
