magibney commented on PR #815: URL: https://github.com/apache/solr/pull/815#issuecomment-1106630764
I became curious about this, since this kind of quasi-reproducible resource-leak classMethod error is a major source of flakiness in tests, and this close/decref reordering on converting to try-with-resources is so subtle. I found several other possible instances; e.g.: in [EmbeddedSolrServer](https://github.com/apache/solr/blob/c99af207c761ec34812ef1cc3054eb2804b7448b/solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java#L191-L277), introduced by 5048456a7a73dd6273fdfe95a3a12167ac827fbc. This may well be worth looking into further ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
