[ https://issues.apache.org/jira/browse/SOLR-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526577#comment-17526577 ]
Mike Drob commented on SOLR-16162: ---------------------------------- Can you give an example of where the full clone takes place? I don't understand the scope of the bug quite as well as you do here. > FilterQuery (`filter([some_query])`) should implement DocSetProducer > -------------------------------------------------------------------- > > Key: SOLR-16162 > URL: https://issues.apache.org/jira/browse/SOLR-16162 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers > Affects Versions: main (10.0) > Reporter: Michael Gibney > Assignee: Michael Gibney > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > There is a substantial practical reason for FilterQuery to implement > DocSetProducer: the way FilterQuery works, it only consults the cache > internally for the backing query; the cache is never directly consulted for > the FilterQuery _per se_. As a consequence, when FilterQuery is used in a > context that wants a DocSet, currently (without implementing DocSetProducer), > a full clone of the cached DocSet must always be built via the Weight > returned by FilterQuery.createWeight(). Implementing DocSetProducer allows to > avoid superfluous DocSet creation. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org