[GitHub] [solr] markrmiller commented on a change in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-02-18 Thread GitBox
markrmiller commented on a change in pull request #585: URL: https://github.com/apache/solr/pull/585#discussion_r810457581 ## File path: solr/modules/s3-repository/build.gradle ## @@ -39,6 +39,10 @@ dependencies { runtimeOnly (group: 'com.fasterxml.woodstox', name: 'woodst

[GitHub] [solr] markrmiller commented on pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-02-18 Thread GitBox
markrmiller commented on pull request #585: URL: https://github.com/apache/solr/pull/585#issuecomment-1045911960 Thanks for taking a look. I have a n update I'll push I'll push tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [solr] markrmiller commented on a change in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-02-18 Thread GitBox
markrmiller commented on a change in pull request #585: URL: https://github.com/apache/solr/pull/585#discussion_r810457300 ## File path: solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java ## @@ -320,17 +340,113 @@ protected URI getBaseUri() thro

[GitHub] [solr] markrmiller commented on a change in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-02-18 Thread GitBox
markrmiller commented on a change in pull request #585: URL: https://github.com/apache/solr/pull/585#discussion_r810457269 ## File path: solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java ## @@ -320,17 +340,113 @@ protected URI getBaseUri() thro

[GitHub] [solr] markrmiller commented on a change in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-02-18 Thread GitBox
markrmiller commented on a change in pull request #585: URL: https://github.com/apache/solr/pull/585#discussion_r810457205 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ## @@ -68,8 +69,12 @@ public static void processParams(SolrRequestHandler ha

[jira] [Commented] (SOLR-15064) Atomic/partial updates to nested docs should not assume _route_ param is the root ID

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494896#comment-17494896 ] ASF subversion and git services commented on SOLR-15064: Commit 2

[GitHub] [solr] dsmiley merged pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_

2022-02-18 Thread GitBox
dsmiley merged pull request #629: URL: https://github.com/apache/solr/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] dsmiley commented on pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
dsmiley commented on pull request #653: URL: https://github.com/apache/solr/pull/653#issuecomment-1045789532 The filestore is its own feature that could be used by something other than packages. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [solr] dsmiley commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
dsmiley commented on a change in pull request #658: URL: https://github.com/apache/solr/pull/658#discussion_r810448586 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -81,6 +81,9 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode sco

[jira] [Commented] (SOLR-12336) Remove Filter from Solr

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494894#comment-17494894 ] ASF subversion and git services commented on SOLR-12336: Commit 3

[jira] [Commented] (SOLR-12336) Remove Filter from Solr

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494893#comment-17494893 ] ASF subversion and git services commented on SOLR-12336: Commit 2

[jira] [Commented] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers

2022-02-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494892#comment-17494892 ] David Smiley commented on SOLR-14401: - In my PR, I did something a bit different than

[GitHub] [solr] Caa52 commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
Caa52 commented on a change in pull request #658: URL: https://github.com/apache/solr/pull/658#discussion_r810423251 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -133,24 +133,8 @@ public void testNullDocIdSet() throws Exception {

[GitHub] [solr] Caa52 commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
Caa52 commented on a change in pull request #658: URL: https://github.com/apache/solr/pull/658#discussion_r810423251 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -133,24 +133,8 @@ public void testNullDocIdSet() throws Exception {

[GitHub] [solr] madrob commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
madrob commented on a change in pull request #658: URL: https://github.com/apache/solr/pull/658#discussion_r810420603 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -133,24 +133,8 @@ public void testNullDocIdSet() throws Exception {

[GitHub] [solr] Caa52 commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
Caa52 commented on a change in pull request #658: URL: https://github.com/apache/solr/pull/658#discussion_r810416385 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -133,24 +133,8 @@ public void testNullDocIdSet() throws Exception {

[GitHub] [solr] Caa52 commented on pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
Caa52 commented on pull request #658: URL: https://github.com/apache/solr/pull/658#issuecomment-1045453377 @madrob please review 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [solr] Caa52 commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
Caa52 commented on a change in pull request #658: URL: https://github.com/apache/solr/pull/658#discussion_r810416385 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -133,24 +133,8 @@ public void testNullDocIdSet() throws Exception {

[GitHub] [solr] Caa52 commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
Caa52 commented on a change in pull request #658: URL: https://github.com/apache/solr/pull/658#discussion_r810415836 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -133,24 +133,8 @@ public void testNullDocIdSet() throws Exception {

[GitHub] [solr] Caa52 opened a new pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet

2022-02-18 Thread GitBox
Caa52 opened a new pull request #658: URL: https://github.com/apache/solr/pull/658 This is a follow-up improvement to the creation of DocSetQuery, reference https://issues.apache.org/jira/browse/SOLR-15257 In the overriden Scorer in `DocSetQuery.createWeight` we do not currently imp

[GitHub] [solr] janhoy commented on pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
janhoy commented on pull request #653: URL: https://github.com/apache/solr/pull/653#issuecomment-1045389490 I would also expect `enable.packages=false` to avoid loading `DistribPackageStore` completely, but it may be needed for other features than pacakge loading? -- This is an automate

[jira] [Commented] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494853#comment-17494853 ] ASF subversion and git services commented on SOLR-15950: Commit 0

[GitHub] [solr] janhoy commented on pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
janhoy commented on pull request #653: URL: https://github.com/apache/solr/pull/653#issuecomment-1045375820 I started looking into it but reverted original commit on main. Then I learned about this PR, which is of course now broken. I'll un-revert again to enable this PR as a solution inst

[GitHub] [solr] dsmiley opened a new pull request #657: SOLR-14401: Track distrib/shard metrics differently

2022-02-18 Thread GitBox
dsmiley opened a new pull request #657: URL: https://github.com/apache/solr/pull/657 * only do for SearchHandler, not all request handlers * track all the same details at the shard level as request (more metrics) * don't limit this to SolrCloud https://issues.apache.org/jira/bro

[jira] [Commented] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494845#comment-17494845 ] ASF subversion and git services commented on SOLR-15950: Commit a

[jira] [Commented] (SOLR-15870) Test TestCollectionAPI fails frequently

2022-02-18 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494842#comment-17494842 ] Jan Høydahl commented on SOLR-15870: Yea, perhaps time to BadApple it, unless it is a

[jira] [Commented] (SOLR-16017) Allow first registered SolrIndexSearcher to inform its configured caches

2022-02-18 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494839#comment-17494839 ] Michael Gibney commented on SOLR-16017: --- That makes perfect sense to me. I do think

[GitHub] [solr] magibney edited a comment on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
magibney edited a comment on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045310607 Well "`fq=filter(foo:bar) OR foo:baz`" is already supported, and this PR wouldn't change that particular example; and yes this example illustrates one reasonable use of `fil

[GitHub] [solr] magibney commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
magibney commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045310607 Well `fq=filter(foo:bar) OR foo:baz` is already supported, and this PR wouldn't change that particular example; and yes this example illustrates one reasonable use of `filter(...)`

[jira] [Reopened] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

2022-02-18 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened SOLR-15950: Reopening to investigate > Create SOLR_HOME/filestore lazily on first use > --

[GitHub] [solr] andywebb1975 commented on pull request #656: trying to make config API work for warming queries

2022-02-18 Thread GitBox
andywebb1975 commented on pull request #656: URL: https://github.com/apache/solr/pull/656#issuecomment-1045237816 ah, didn't mean to open this in the main project! But if anyone has thoughts on how to resolve https://issues.apache.org/jira/browse/SOLR-9359 please let me know :-) --

[GitHub] [solr] andywebb1975 closed pull request #656: trying to make config API work for warming queries

2022-02-18 Thread GitBox
andywebb1975 closed pull request #656: URL: https://github.com/apache/solr/pull/656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [solr] andywebb1975 opened a new pull request #656: trying to make config API work for warming queries

2022-02-18 Thread GitBox
andywebb1975 opened a new pull request #656: URL: https://github.com/apache/solr/pull/656 *VERY* hacky experimentation to get the Config API working for warming queries https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a s

[GitHub] [solr] madrob edited a comment on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
madrob edited a comment on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045228394 So the use case we're trying to support is "fq=filter(foo:bar) OR foo:baz"? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] madrob commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
madrob commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045228394 So the use case we're trying to support is fq=filter(foo:bar OR foo:baz)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (SOLR-9575) Allow starting with an empty SOLR_HOME

2022-02-18 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494818#comment-17494818 ] Jan Høydahl commented on SOLR-9575: --- Thanks for completing this Houston! > Allow starti

[GitHub] [solr] magibney commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
magibney commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045163521 Sorry, I misunderstood what you meant in your [comment above](#pullrequestreview-887690496). But in any event I still think the concern is not warranted: 1. `fq=filter({!cac

[GitHub] [solr] HoustonPutman commented on a change in pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
HoustonPutman commented on a change in pull request #653: URL: https://github.com/apache/solr/pull/653#discussion_r810322533 ## File path: solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java ## @@ -563,28 +562,14 @@ public static boolean isMetaDataFile(String

[GitHub] [solr] magibney commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
magibney commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045139273 I think I follow? Yes, FilterQuery here is as in `FilterQuery.java`, which is really specific, almost always invoked via `filter([backing_query])`, when you want consult the filter

[GitHub] [solr] madrob commented on a change in pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
madrob commented on a change in pull request #653: URL: https://github.com/apache/solr/pull/653#discussion_r810304779 ## File path: solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java ## @@ -563,28 +562,14 @@ public static boolean isMetaDataFile(String file) {

[GitHub] [solr] dsmiley commented on pull request #645: SOLR-15333 Fix SpatialRecursivePrefixTreeFieldType schema definition warnings

2022-02-18 Thread GitBox
dsmiley commented on pull request #645: URL: https://github.com/apache/solr/pull/645#issuecomment-1045110189 Ah; it's surrounded by so much other code that I simply didn't notice ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [solr] dsmiley commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
dsmiley commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045107279 The fact that `FilterQuery` != `fq` was something I was toying with today -- maybe it *should*, which would be more intuitive. -- This is an automated message from the Apache Git

[GitHub] [solr] dsmiley commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
dsmiley commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045104899 > Does this mean that local params fq={!cache=false}foo:bar would no longer work? No, it doesn't mean that. It's confusing but `FilterQuery` != `fq` param. -- This is an a

[jira] [Updated] (SOLR-16022) Improve security ui

2022-02-18 Thread Weaver (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weaver updated SOLR-16022: -- Description: When changing user passwords through the Security UI, the password is required to follow a complex

[GitHub] [solr] madrob edited a comment on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
madrob edited a comment on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045094828 > what I didn't like about it is that it blocks using FilterQuery to mean filter but not cache. Does this mean that local params `fq={!cache=false}foo:bar` would no long

[GitHub] [solr] madrob commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
madrob commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1045094828 > what I didn't like about it is that it blocks using FilterQuery to mean filter but not cache. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [solr] madrob commented on pull request #645: SOLR-15333 Fix SpatialRecursivePrefixTreeFieldType schema definition warnings

2022-02-18 Thread GitBox
madrob commented on pull request #645: URL: https://github.com/apache/solr/pull/645#issuecomment-1045092560 Oh, I see, I misunderstood your question, then. The test you wrote is still at the heart of the method https://github.com/apache/solr/commit/7f620c7a10006f344ff660d28b17298372f102fd#

[GitHub] [solr] dsmiley commented on pull request #645: SOLR-15333 Fix SpatialRecursivePrefixTreeFieldType schema definition warnings

2022-02-18 Thread GitBox
dsmiley commented on pull request #645: URL: https://github.com/apache/solr/pull/645#issuecomment-1045082592 Right thanks but that doesn't directly address my question. I liked the simplicity of the test I wrote. Any way, thanks for shepherding this one through Mike. -- This is an au

[jira] [Commented] (SOLR-16017) Allow first registered SolrIndexSearcher to inform its configured caches

2022-02-18 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494800#comment-17494800 ] Mike Drob commented on SOLR-16017: -- I'm of two minds here... If we end up deciding that

[jira] [Commented] (SOLR-16017) Allow first registered SolrIndexSearcher to inform its configured caches

2022-02-18 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494784#comment-17494784 ] Michael Gibney commented on SOLR-16017: --- If you think the "consistency" motivation

[GitHub] [solr] madrob commented on a change in pull request #654: SOLR-6443: Cleanup managedResourceTest

2022-02-18 Thread GitBox
madrob commented on a change in pull request #654: URL: https://github.com/apache/solr/pull/654#discussion_r810266482 ## File path: solr/core/src/test/org/apache/solr/rest/TestManagedResourceStorage.java ## @@ -36,28 +35,19 @@ /** * Depends on ZK for testing ZooKeeper backe

[jira] [Created] (SOLR-16022) Users unable to login after upgrade

2022-02-18 Thread Weaver (Jira)
Weaver created SOLR-16022: - Summary: Users unable to login after upgrade Key: SOLR-16022 URL: https://issues.apache.org/jira/browse/SOLR-16022 Project: Solr Issue Type: Bug Security Level: Publ

[GitHub] [solr] HoustonPutman commented on pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
HoustonPutman commented on pull request #653: URL: https://github.com/apache/solr/pull/653#issuecomment-1045002903 Opened a separate PR for the test cleanup: #654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [solr] magibney edited a comment on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
magibney edited a comment on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1044819245 Hmm... the danger with that is that although FilterQuery _does_ wrap a query, the semantics of WrappedQuery are that the inner query should be accessible, and that at a cert

[GitHub] [solr] HoustonPutman opened a new pull request #654: SOLR-6443: Cleanup managedResourceTest

2022-02-18 Thread GitBox
HoustonPutman opened a new pull request #654: URL: https://github.com/apache/solr/pull/654 Mainly remove the need for a SolrCore in the test. https://issues.apache.org/jira/browse/SOLR-6443 -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [solr] HoustonPutman commented on pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_

2022-02-18 Thread GitBox
HoustonPutman commented on pull request #629: URL: https://github.com/apache/solr/pull/629#issuecomment-1044981233 I think `getSelfOrNestedDocIdStr` is definitely clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [solr] risdenk commented on pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
risdenk commented on pull request #653: URL: https://github.com/apache/solr/pull/653#issuecomment-1044977897 I can confirm this at least makes `org.apache.solr.rest.TestManagedResourceStorage` pass which has been failing on main. ``` ./gradlew :solr:core:test --tests "org.apache

[jira] [Reopened] (SOLR-15870) Test TestCollectionAPI fails frequently

2022-02-18 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reopened SOLR-15870: --- Unfortunately this is still failing roughly 10% of runs. > Test TestCollectionAPI fails frequent

[jira] [Commented] (SOLR-15333) Solr-demo in docker uses improper configuration for SpatialRecursivePrefixTreeFieldType

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494771#comment-17494771 ] ASF subversion and git services commented on SOLR-15333: Commit 7

[GitHub] [solr] madrob merged pull request #645: SOLR-15333 Fix SpatialRecursivePrefixTreeFieldType schema definition warnings

2022-02-18 Thread GitBox
madrob merged pull request #645: URL: https://github.com/apache/solr/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] HoustonPutman opened a new pull request #653: SOLR-15950: Fix auto-creation of filestore in constructor.

2022-02-18 Thread GitBox
HoustonPutman opened a new pull request #653: URL: https://github.com/apache/solr/pull/653 https://issues.apache.org/jira/browse/SOLR-15950 Note that I am also removing the need to create a SolrCore in the Managed Resource test. This is completely unrelated, but I saw that it wasn't

[GitHub] [solr] madrob commented on a change in pull request #648: SOLR-16019 Query parsing exception return HTTP 400 instead of 500

2022-02-18 Thread GitBox
madrob commented on a change in pull request #648: URL: https://github.com/apache/solr/pull/648#discussion_r810232005 ## File path: solr/core/src/test/org/apache/solr/servlet/HttpSolrCallCloudTest.java ## @@ -54,19 +54,28 @@ public static void setupCluster() throws Exception {

[GitHub] [solr] HoustonPutman commented on a change in pull request #652: SOLR-16021: Improve docs for S3 location option

2022-02-18 Thread GitBox
HoustonPutman commented on a change in pull request #652: URL: https://github.com/apache/solr/pull/652#discussion_r810231220 ## File path: solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc ## @@ -671,9 +671,27 @@ This plugin uses the https://docs.aws.amaz

[GitHub] [solr] madrob commented on a change in pull request #652: SOLR-16021: Improve docs for S3 location option

2022-02-18 Thread GitBox
madrob commented on a change in pull request #652: URL: https://github.com/apache/solr/pull/652#discussion_r810226694 ## File path: solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc ## @@ -671,9 +671,27 @@ This plugin uses the https://docs.aws.amazon.com/

[GitHub] [solr-operator] nickumia-reisys commented on issue #399: Random Loss of Credentials

2022-02-18 Thread GitBox
nickumia-reisys commented on issue #399: URL: https://github.com/apache/solr-operator/issues/399#issuecomment-1044915399 I'm so sorry for the delay! We've had a few other issues that we've had to work through. Updated timeline: We should have the results by the end of next week.

[jira] [Commented] (SOLR-16017) Allow first registered SolrIndexSearcher to inform its configured caches

2022-02-18 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494756#comment-17494756 ] Michael Gibney commented on SOLR-16017: --- {quote}Do you have custom caches that are

[jira] [Commented] (SOLR-16017) Allow first registered SolrIndexSearcher to inform its configured caches

2022-02-18 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494744#comment-17494744 ] Mike Drob commented on SOLR-16017: -- >The patch currently doesn't introduce anything that

[GitHub] [solr] madrob commented on a change in pull request #646: SOLR-16017: Allow first registered SolrIndexSearcher to inform its configured caches

2022-02-18 Thread GitBox
madrob commented on a change in pull request #646: URL: https://github.com/apache/solr/pull/646#discussion_r810195977 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -2395,6 +2395,7 @@ public IndexFingerprint getIndexFingerprint(SolrIndexSearcher sear

[GitHub] [solr] HoustonPutman opened a new pull request #652: SOLR-16021: Improve docs for S3 location option

2022-02-18 Thread GitBox
HoustonPutman opened a new pull request #652: URL: https://github.com/apache/solr/pull/652 https://issues.apache.org/jira/browse/SOLR-16021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [solr] dsmiley commented on pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_

2022-02-18 Thread GitBox
dsmiley commented on pull request #629: URL: https://github.com/apache/solr/pull/629#issuecomment-1044844311 Great point Houston. While I'm at it, I rather unlike the method name for getChildDocIdStr. As documented, it's the ID for the document itself -- and for a typical doc, it's *not*

[jira] [Commented] (SOLR-14928) Remove Overseer ClusterStateUpdater

2022-02-18 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494736#comment-17494736 ] Ilan Ginzburg commented on SOLR-14928: -- If I remember correctly, the no Overseer opt

[jira] [Commented] (SOLR-13989) Migrate hadoop authentication code to a module

2022-02-18 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494726#comment-17494726 ] Kevin Risden commented on SOLR-13989: - Merged to main and 9x for now. Will merge to 9

[GitHub] [solr] magibney commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
magibney commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1044819245 Hmm... the danger with that is that although FilterQuery _does_ wrap a query, the semantics of WrappedQuery are that the inner query should be accessible, and that at a certain poi

[jira] [Created] (SOLR-16021) Improve documentation around the location parameter for S3 Backups

2022-02-18 Thread Houston Putman (Jira)
Houston Putman created SOLR-16021: - Summary: Improve documentation around the location parameter for S3 Backups Key: SOLR-16021 URL: https://issues.apache.org/jira/browse/SOLR-16021 Project: Solr

[jira] [Commented] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

2022-02-18 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494715#comment-17494715 ] Kevin Risden commented on SOLR-15950: - FYI it looks like there are reproducible error

[GitHub] [solr] dsmiley commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-18 Thread GitBox
dsmiley commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1044808293 WrappedQuery would then be non-final, but it's constructor would be package-private to restrain abuse. Instead it could have a "wrap" static. For even greater ease-of-use, that wr

[GitHub] [solr] risdenk commented on pull request #637: SOLR-15904: Create sql module

2022-02-18 Thread GitBox
risdenk commented on pull request #637: URL: https://github.com/apache/solr/pull/637#issuecomment-1044798261 If you use the PR in github and viewed files it shows exactly what changed. But yea I can try to avoid force pushing. Its clearer to me to make sure the commit is exactly what shoul

[GitHub] [solr] HoustonPutman commented on pull request #637: SOLR-15904: Create sql module

2022-02-18 Thread GitBox
HoustonPutman commented on pull request #637: URL: https://github.com/apache/solr/pull/637#issuecomment-1044796437 @risdenk would you mind not force-pushing your changes? Makes it hard to see what has changed since I last viewed. It's easy to squash and merge in the end anyways 🙂 -- Th

[jira] [Commented] (SOLR-13989) Migrate hadoop authentication code to a module

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494710#comment-17494710 ] ASF subversion and git services commented on SOLR-13989: Commit 7

[jira] [Commented] (SOLR-13989) Migrate hadoop authentication code to a module

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494705#comment-17494705 ] ASF subversion and git services commented on SOLR-13989: Commit e

[GitHub] [solr] risdenk merged pull request #636: SOLR-13989: Create hadoop-auth module

2022-02-18 Thread GitBox
risdenk merged pull request #636: URL: https://github.com/apache/solr/pull/636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Resolved] (SOLR-9575) Allow starting with an empty SOLR_HOME

2022-02-18 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-9575. -- Resolution: Fixed > Allow starting with an empty SOLR_HOME > ---

[jira] [Commented] (SOLR-9575) Allow starting with an empty SOLR_HOME

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494700#comment-17494700 ] ASF subversion and git services commented on SOLR-9575: --- Commit a7a3

[jira] [Commented] (SOLR-9575) Allow starting with an empty SOLR_HOME

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494699#comment-17494699 ] ASF subversion and git services commented on SOLR-9575: --- Commit 63d1

[jira] [Commented] (SOLR-16018) Auto-link JIRA issues in ref guide

2022-02-18 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494698#comment-17494698 ] Houston Putman commented on SOLR-16018: --- Agreed with Cassandra. I think this would

[jira] [Commented] (SOLR-9575) Allow starting with an empty SOLR_HOME

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494695#comment-17494695 ] ASF subversion and git services commented on SOLR-9575: --- Commit 9155

[GitHub] [solr] HoustonPutman merged pull request #651: SOLR-9575: Use default solr.xml in install_solr_service

2022-02-18 Thread GitBox
HoustonPutman merged pull request #651: URL: https://github.com/apache/solr/pull/651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Updated] (SOLR-15943) Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376

2022-02-18 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15943: Fix Version/s: 9.0 Resolution: Fixed Status: Resolved (was: Patch Available) > S

[jira] [Commented] (SOLR-15943) Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494694#comment-17494694 ] ASF subversion and git services commented on SOLR-15943: Commit 9

[jira] [Commented] (SOLR-15943) Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494692#comment-17494692 ] ASF subversion and git services commented on SOLR-15943: Commit 8

[jira] [Commented] (SOLR-15943) Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376

2022-02-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494693#comment-17494693 ] ASF subversion and git services commented on SOLR-15943: Commit 2

[GitHub] [solr] risdenk merged pull request #650: SOLR-15943: Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376

2022-02-18 Thread GitBox
risdenk merged pull request #650: URL: https://github.com/apache/solr/pull/650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] janhoy commented on pull request #636: SOLR-13989: Create hadoop-auth module

2022-02-18 Thread GitBox
janhoy commented on pull request #636: URL: https://github.com/apache/solr/pull/636#issuecomment-1044730856 No futher comments, but I have not and will not walk through it all. I trust that if all tests pass after the move, and that it survives a few days of Jenkins massage on main branch,

[jira] [Updated] (SOLR-15731) Separate out a solrj-jdbc module

2022-02-18 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15731: Component/s: Parallel SQL > Separate out a solrj-jdbc module > > >

[jira] [Updated] (SOLR-8680) Distribute JDBC driver as a separate jar

2022-02-18 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8680: --- Component/s: Parallel SQL > Distribute JDBC driver as a separate jar > ---

[GitHub] [solr] madrob commented on pull request #645: SOLR-15333 Fix SpatialRecursivePrefixTreeFieldType schema definition warnings

2022-02-18 Thread GitBox
madrob commented on pull request #645: URL: https://github.com/apache/solr/pull/645#issuecomment-1044622276 You're in the co author line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [solr] risdenk commented on pull request #637: SOLR-15904: Create sql module

2022-02-18 Thread GitBox
risdenk commented on pull request #637: URL: https://github.com/apache/solr/pull/637#issuecomment-1044609919 > The biggest outstanding item is fixing the Implicit Plugins to handle this better. Right now it works, but only if SQL handler is enabled. It breaks otherwise. So need to look int

[GitHub] [solr] risdenk commented on pull request #621: SOLR-15989: Upgrade to Tika 1.28.1

2022-02-18 Thread GitBox
risdenk commented on pull request #621: URL: https://github.com/apache/solr/pull/621#issuecomment-1044608615 Thanks @dsmiley I'll merge this after PR https://github.com/apache/solr/pull/553 due to the guava upgrade. @tballison if you have any comments/thoughts on this please do comme

[GitHub] [solr] risdenk commented on pull request #618: SOLR-15990: Use google-cloud-bom for gcs-repository dependencies

2022-02-18 Thread GitBox
risdenk commented on pull request #618: URL: https://github.com/apache/solr/pull/618#issuecomment-1044607688 Thanks @gerlowskija I'll merge this after PR #553 due to the guava upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] risdenk commented on pull request #636: SOLR-13989: Create hadoop-auth module

2022-02-18 Thread GitBox
risdenk commented on pull request #636: URL: https://github.com/apache/solr/pull/636#issuecomment-1044606328 @janhoy @HoustonPutman @madrob any other comments on this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

  1   2   >