madrob commented on pull request #645: URL: https://github.com/apache/solr/pull/645#issuecomment-1045092560
Oh, I see, I misunderstood your question, then. The test you wrote is still at the heart of the method https://github.com/apache/solr/commit/7f620c7a10006f344ff660d28b17298372f102fd#diff-126773ac5b95d785af0278f711cf6cbcc33fc7913036fbf4780c81bf6f445062R1194-R1199 but I added the LogListener decorator and a few negative conditions after it. Those could have been three different test cases, I suppose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
