magibney commented on pull request #624:
URL: https://github.com/apache/solr/pull/624#issuecomment-1045139273
I think I follow? Yes, FilterQuery here is as in `FilterQuery.java`, which
is really specific, almost always invoked via `filter([backing_query])`, when
you want consult the filterCache for the backing query in a context where it
would normally _not_ consult the filterCache. This is particulary useful, e.g.,
for fine-grained control of how subclauses in queries are cached. That
use-case/concept doesn't go away if there's a closer relationship between `fq`
and `FilterQuery` ... if anything I could see renaming `FilterQuery` to be more
clearly distinct from `fq` (in fact, it's hard to search Jira for issues
related to `FilterQuery` because that term is indeed often used informally to
refer to `fq`).
So, just to clarify, your [comment above](#pullrequestreview-887690496)
should no longer be a concern (i.e., `fq={!cache=false}foo:bar` would
definitely still work as it currently does)? What this PR does is make it so
that `fq=filter(foo:bar)` would only cache one query, not two. And, for good
measure, `fq={!cache=false}filter(foo:bar)` would still hit the filterCache
_via the `filter(...)` wrapper_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
