magibney edited a comment on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1044819245
Hmm... the danger with that is that although FilterQuery _does_ wrap a query, the semantics of WrappedQuery are that the inner query should be accessible, and that at a certain point in the docset-creation-from-query code it is proper to "unwrap" the query and run the inner query. The semantics of FilterQuery are different. If there's a way to provide access to the backing query, it can't/shouldn't be leveraged in the same way that it is for WrappedQuery, so the "instanceof" checks for WrappedQuery would not be appropriate to use I think. What if FilterQuery (which already extends ExtendedQueryBase) simply overrode `getCache()` to be final and always return `false`? Then we'd have the "paradoxically" note in that overridden method, no special cases in SIS. EDIT: I took a crack at this approach with 2df8cf0b87916d829097097bc6e88fa6db5a4113, and I do think it's cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
