dsmiley commented on pull request #629: URL: https://github.com/apache/solr/pull/629#issuecomment-1044844311
Great point Houston. While I'm at it, I rather unlike the method name for getChildDocIdStr. As documented, it's the ID for the document itself -- and for a typical doc, it's *not* a child document. Perhaps this could be named `getSelfOrNestedDocIdStr` ? I recall the problem I was avoiding was making the method name something simple like `getDocIdStr` because it's too tempting to call this when the caller really ought to be calling `getIndexedId`[Str] in most cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
