[
https://issues.apache.org/jira/browse/SOLR-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494839#comment-17494839
]
Michael Gibney commented on SOLR-16017:
---------------------------------------
That makes perfect sense to me. I do think that this particular API extension
is clearly enough a prerequisite for the segment-aware cache that bundling it
together makes good sense. And I definitely relate to "often I don't know what
the correct API is until I've actually implemented something". I'll create a
new issue for the segment-aware cache and link to this issue. (There are a
couple of other issues that are tangentially related that, even if they could
be justified in the absence of the segment-aware cache, the case for
backporting would be much clearer as followups to the segment-aware cache,
if/when it's merged/backported).
Thanks for taking the time to explain your perspective on this!
> Allow first registered SolrIndexSearcher to inform its configured caches
> ------------------------------------------------------------------------
>
> Key: SOLR-16017
> URL: https://issues.apache.org/jira/browse/SOLR-16017
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Affects Versions: main (10.0)
> Reporter: Michael Gibney
> Priority: Trivial
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Each configured cache is currently informed of its associated
> SolrIndexSearcher when SolrCore calls the {{SolrIndexSearcher.warm(...)}},
> which in turn calls {{SolrCache.warm(...)}}, passing the searcher as an
> argument.
> It is inconsistent that caches are informed of subsequent searchers, but not
> of the first registered searcher. A note on
> [SolrCache.warm|https://github.com/apache/solr/blob/9903d00b0fb6216f836bb580f42d0081b7b41584/solr/core/src/java/org/apache/solr/search/SolrCache.java#L144-L150]
> suggests the possibility of providing the SolrIndexSearcher on
> cache.init(...). That seems reasonable to me, and would be one way to resolve
> the current inconsistency. But that would likely constitute a major change,
> perhaps involving a change in the SolrCache plugin API, and the
> responsibility of each cache to maintain its own reference to its associated
> searcher.
> Another way to resolve the current inconsistency would be to introduce a
> method to (analogous to {{warm(...)}}) that the first registered
> SolrIndexSearcher could use to inform its caches.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
