Aljoscha Krettek created FLINK-4579:
---
Summary: Add StateBackendFactory for RocksDB Backend
Key: FLINK-4579
URL: https://issues.apache.org/jira/browse/FLINK-4579
Project: Flink
Issue Type: B
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2472
[FLINK-4361] Introduce Flink's own future abstraction
Flink's future abstraction whose API is similar to Java 8's
CompletableFuture.
That's in order to ease a future transition to this clas
[
https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464401#comment-15464401
]
ASF GitHub Bot commented on FLINK-4361:
---
GitHub user tillrohrmann opened a pull requ
[
https://issues.apache.org/jira/browse/FLINK-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464437#comment-15464437
]
ASF GitHub Bot commented on FLINK-4265:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2294
Sorry for the late reply @greghogan.
+1 from me as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2461
Hi @wangzhijiang999, maybe we should start simple without introducing a
factory method, because there might actually be not many cases to distinguish.
Maybe we could rename the `TaskManagerFacto
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464459#comment-15464459
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorenz Bühmann updated FLINK-2662:
--
Attachment: FlinkBug.scala
A minimal example that leads to the reported exception. While keeping
[
https://issues.apache.org/jira/browse/FLINK-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464487#comment-15464487
]
Lorenz Bühmann edited comment on FLINK-2662 at 9/5/16 8:53 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464487#comment-15464487
]
Lorenz Bühmann edited comment on FLINK-2662 at 9/5/16 8:55 AM:
-
Till Rohrmann created FLINK-4580:
Summary: Check that the RpcEndpoint supports the specified
RpcGateway
Key: FLINK-4580
URL: https://issues.apache.org/jira/browse/FLINK-4580
Project: Flink
I
[
https://issues.apache.org/jira/browse/FLINK-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464508#comment-15464508
]
Fabian Hueske commented on FLINK-2662:
--
Thanks a lot [~LorenzB]! This will be very he
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464542#comment-15464542
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464540#comment-15464540
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464553#comment-15464553
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user StephanEwen commented on the is
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464544#comment-15464544
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2456#discussion_r77492066
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskExecutionStateListener.java
---
@@ -0,0 +1,29 @@
+/*
+ * Licensed
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2456#discussion_r77492004
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/InputSplitProvider.java
---
@@ -35,4 +35,16 @@
* task shal
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464529#comment-15464529
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2456#discussion_r77491885
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/CheckpointNotifier.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the A
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2450
Quick question: The `ForkableFlinkMiniCluster` was something semi-public,
in the sense that it was part of the `flink-test-utils` project and used by
quite a few users. So this would be a breakin
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2456
I think this is good.
Few comments inline on the names, the hardest problem usually ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464545#comment-15464545
]
Till Rohrmann commented on FLINK-4451:
--
Fixed via 0cf2a822b6872ee4f3f0c99f0fcee71affa
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77494182
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala
---
@@ -112,7 +112,7 @@ object FlinkRuleSets {
[
https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464573#comment-15464573
]
ASF GitHub Bot commented on FLINK-4546:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464574#comment-15464574
]
ASF GitHub Bot commented on FLINK-4546:
---
Github user fhueske commented on a diff in
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @wuchong, thanks for the PR. Just had two minor comments. Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
[
https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464577#comment-15464577
]
ASF GitHub Bot commented on FLINK-4546:
---
Github user fhueske commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2471
Thank your for reporting this issue. The Apache Flink project uses JIRA to
track issues, not GitHub pull requests, so it would be nice if you could close
this PR and file a ticket on
[JIRA](https://i
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77494279
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala
---
@@ -18,22 +18,11 @@
package
[
https://issues.apache.org/jira/browse/FLINK-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-4513:
--
Fix Version/s: (was: 1.1.2)
1.1.3
> Kafka connector documentation refers
[
https://issues.apache.org/jira/browse/FLINK-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-4396:
--
Fix Version/s: (was: 1.1.2)
1.1.3
> GraphiteReporter class not found at s
[
https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-4329:
--
Fix Version/s: (was: 1.1.2)
1.1.3
> Fix Streaming File Source Timestamps/
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
build success
```
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 01:28 h
[INFO] Finished at: 2016-0
GitHub user liuyuzhong reopened a pull request:
https://github.com/apache/flink/pull/2452
[Flink-4450] add a new module "flink-apache-storm" to support new storm
verion program (higher than 1.0.0)
@StephanEwen
1. Create new module "flink-apache-storm" copy from
flink-cont
Github user liuyuzhong closed the pull request at:
https://github.com/apache/flink/pull/2452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2473
[FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at
connect time
When calling RpcService.connect it is checked that the rpc endpoint
supports the specified
rpc gate
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464682#comment-15464682
]
ASF GitHub Bot commented on FLINK-4580:
---
GitHub user tillrohrmann opened a pull requ
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2450
Yes that is true. However, the `flink-test-utils` have not been guaranteed
to be stable if I'm not mistaken. The changes one has to apply is to replace
the `ForkableFlinkMiniCluster` with the `L
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464700#comment-15464700
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user tillrohrmann commented on the i
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
Yes, that also make sense. For testing purpose it is very clear, so we do
not need do anything currently, all the components in `TaskManager` constructor
can be mocked implicitly.
Fo
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464709#comment-15464709
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user wangzhijiang999 commented on th
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2450
I will re-introduce the `ForkableFlinkMiniCluster` which is simply
extending the `LocalFlinkMiniCluster`.
---
If your project is set up for it, you can reply to this email and have your
reply a
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464765#comment-15464765
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user tillrohrmann commented on the i
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77507678
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala
---
@@ -18,22 +18,11 @@
package
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2461
I think you should have at least another method `startComponents` which
starts the different components. Everything else can be added later when we see
that it would be helpful.
---
If your pr
[
https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464771#comment-15464771
]
ASF GitHub Bot commented on FLINK-4546:
---
Github user wuchong commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464772#comment-15464772
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464784#comment-15464784
]
ASF GitHub Bot commented on FLINK-4546:
---
Github user wuchong commented on the issue:
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @fhueske , thanks for reviewing, I updated this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2456#discussion_r77508238
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/CheckpointNotifier.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464788#comment-15464788
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2456#discussion_r77508870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/InputSplitProvider.java
---
@@ -35,4 +35,16 @@
* task sha
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464799#comment-15464799
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2456#discussion_r77508917
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskExecutionStateListener.java
---
@@ -0,0 +1,29 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464801#comment-15464801
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464832#comment-15464832
]
Jark Wu commented on FLINK-4579:
+1 for adding rocksdb to the standard distribution lib. S
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
Thank you. Testing again and merging if nothing fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
[
https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464874#comment-15464874
]
ASF GitHub Bot commented on FLINK-3929:
---
Github user mxm commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2456
I've addressed the comments. In order to solve the problem with the user
code class loader, I decided to pass it into the `InputSplitProvider` via the
`getNextInputSplit` method. That way, we do
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464910#comment-15464910
]
ASF GitHub Bot commented on FLINK-4456:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2450
I've re-introduced the `ForkableFlinkMiniCluster`. However, this time it
only starts the normal distributed component classes (e.g. `JobManager` instead
of `TestingJobManager`, etc.). This impli
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464917#comment-15464917
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465000#comment-15465000
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77522339
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
publi
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465005#comment-15465005
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77522737
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -131,9 +149,16 @@ public RegistrationResponse
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77523806
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ * L
[
https://issues.apache.org/jira/browse/FLINK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465025#comment-15465025
]
Aljoscha Krettek commented on FLINK-4579:
-
Should be as easy as that, yes.
> Add
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465023#comment-15465023
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465028#comment-15465028
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77523985
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
---
@@ -32,4 +33,11 @@
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77524239
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotStatus.java
---
@@ -46,13 +47,21 @@
/** if the slot is allocated
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465037#comment-15465037
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77524466
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ * L
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465044#comment-15465044
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465054#comment-15465054
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77524626
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
@@ -15,11 +15,27 @@
* See the License fo
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2463
Thanks for your work @mxm. I've had some comments which you can find
inline. I think the implementation of the slot request logic made another step
in the right direction with this PR.
---
If
[
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465061#comment-15465061
]
ASF GitHub Bot commented on FLINK-4538:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77527444
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
---
@@ -35,109 +46,111 @@
final Map taskM
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465100#comment-15465100
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465103#comment-15465103
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77527637
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
---
@@ -35,109 +46,111 @@
final Map taskM
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77527822
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465106#comment-15465106
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77527854
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465108#comment-15465108
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77528207
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
@@ -0,0 +1,269 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77528158
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
@@ -0,0 +1,269 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465112#comment-15465112
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465111#comment-15465111
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77528928
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java
---
@@ -25,6 +25,7 @@
public static final byte METRI
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465122#comment-15465122
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r77529056
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java
---
@@ -25,6 +25,7 @@
public static final byte METRI
[
https://issues.apache.org/jira/browse/FLINK-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels resolved FLINK-4073.
---
Resolution: Fixed
Assignee: Maximilian Michels
Fix Version/s: 1.2.0
Fi
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465125#comment-15465125
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2363
I think the changes look good. Thanks for your work @zentol :-) I only had
a minor question whether we can substitute the explicit category information by
the type information of the metric dump
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465132#comment-15465132
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465144#comment-15465144
]
ASF GitHub Bot commented on FLINK-3929:
---
Github user mxm commented on the issue:
1 - 100 of 125 matches
Mail list logo
