[ https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464910#comment-15464910 ]
ASF GitHub Bot commented on FLINK-4456: --------------------------------------- Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2456 I've addressed the comments. In order to solve the problem with the user code class loader, I decided to pass it into the `InputSplitProvider` via the `getNextInputSplit` method. That way, we don't have to know the user code class loader when creating the `InputSplitProvider` implementation. > Replace ActorGateway in Task by interface > ----------------------------------------- > > Key: FLINK-4456 > URL: https://issues.apache.org/jira/browse/FLINK-4456 > Project: Flink > Issue Type: Improvement > Components: TaskManager > Reporter: Till Rohrmann > Assignee: Till Rohrmann > > The {{Task}} communicates with the outside world ({{JobManager}} and > {{TaskManager}}) via {{ActorGateways}}. This bakes in the dependency on > actors. > In terms of modularization and an improved abstraction (especially wrt > Flip-6) I propose to replace the {{ActorGateways}} by interfaces which > exposes the required methods. The current implementation would then simply > wrap the method calls in messages and send them via the {{ActorGateway}} to > the recipient. > In Flip-6 the {{JobMaster}} could simply implement these interfaces as part > of their RPC contract. -- This message was sent by Atlassian JIRA (v6.3.4#6332)