[
https://issues.apache.org/jira/browse/FLINK-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464771#comment-15464771
]
ASF GitHub Bot commented on FLINK-4546:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77507678
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala
---
@@ -18,22 +18,11 @@
package org.apache.flink.api.table.plan.schema
-import org.apache.calcite.rel.`type`.{RelDataType, RelDataTypeFactory}
-import org.apache.flink.api.table.FlinkTypeFactory
import org.apache.flink.streaming.api.datastream.DataStream
class DataStreamTable[T](
val dataStream: DataStream[T],
override val fieldIndexes: Array[Int],
override val fieldNames: Array[String])
extends FlinkTable[T](dataStream.getType, fieldIndexes, fieldNames) {
-
- override def getRowType(typeFactory: RelDataTypeFactory): RelDataType = {
--- End diff --
Because this override method is almost the same with super method. I
remove it to keep consistent with `DataSetTable` which do not override the
`getRowType` method.
> Remove STREAM keyword in Stream SQL
> ------------------------------------
>
> Key: FLINK-4546
> URL: https://issues.apache.org/jira/browse/FLINK-4546
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Jark Wu
>
> It is about to unify Batch SQL and Stream SQL grammar, esp. removing STREAM
> keyword in Stream SQL.
> detailed discuss mailing list:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Some-thoughts-about-unify-Stream-SQL-and-Batch-SQL-grammer-td13060.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
