Github user wangzhijiang999 commented on the issue:

    https://github.com/apache/flink/pull/2461
  
    Yes, that also make sense. For testing purpose it is very clear, so we do 
not need do anything currently, all the components in `TaskManager` constructor 
can be mocked implicitly.
    
    For `TaskManagerRunner`, the purpose is to pull out the initialization of 
related components from `TaskManager` to make it logic clear. Just one issue to 
be confirmed, we should provide more static methods of different parameter 
units for outside world or just one static method such as 
'selectNetworkInterfaceAndRunTaskManager(`Configuration` 
configuration,`ResourceID` resourceID) '? 
    I think providing more methods with different parameters may be reasonable, 
because some parameters such as 'hostname','port', `RpcService`, 
`HighAvailabilityServices` may want to be passed from outside.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to