[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464709#comment-15464709
]
ASF GitHub Bot commented on FLINK-4505:
---------------------------------------
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
Yes, that also make sense. For testing purpose it is very clear, so we do
not need do anything currently, all the components in `TaskManager` constructor
can be mocked implicitly.
For `TaskManagerRunner`, the purpose is to pull out the initialization of
related components from `TaskManager` to make it logic clear. Just one issue to
be confirmed, we should provide more static methods of different parameter
units for outside world or just one static method such as
'selectNetworkInterfaceAndRunTaskManager(`Configuration`
configuration,`ResourceID` resourceID) '?
I think providing more methods with different parameters may be reasonable,
because some parameters such as 'hostname','port', `RpcService`,
`HighAvailabilityServices` may want to be passed from outside.
> Implement TaskManagerFactory to bring up TaskManager for different modes
> ------------------------------------------------------------------------
>
> Key: FLINK-4505
> URL: https://issues.apache.org/jira/browse/FLINK-4505
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
> Priority: Minor
>
> Implement {{TaskExecutorFactory}} that should be an abstract class with the
> helper methods to bring up the {{TaskManager}}. The factory can be
> implemented by some classes to start a {{TaskManager}} in different modes
> (testing, standalone, yarn).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
