[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464540#comment-15464540
]
ASF GitHub Bot commented on FLINK-4456:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2456#discussion_r77491885
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/CheckpointNotifier.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.taskmanager;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.state.ChainedStateHandle;
+import org.apache.flink.runtime.state.KeyGroupsStateHandle;
+import org.apache.flink.runtime.state.StreamStateHandle;
+
+import java.util.List;
+
+/**
+ * Notifier for checkpoint acknowledge and decline messages in the {@link
Task}.
+ */
+public interface CheckpointNotifier {
--- End diff --
`CheckpointNotifier` is already used for user functions, as an interface to
get notifications on completed checkpoints.
How about calling this `CheckpointResponder` or something like that instead?
> Replace ActorGateway in Task by interface
> -----------------------------------------
>
> Key: FLINK-4456
> URL: https://issues.apache.org/jira/browse/FLINK-4456
> Project: Flink
> Issue Type: Improvement
> Components: TaskManager
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{Task}} communicates with the outside world ({{JobManager}} and
> {{TaskManager}}) via {{ActorGateways}}. This bakes in the dependency on
> actors.
> In terms of modularization and an improved abstraction (especially wrt
> Flip-6) I propose to replace the {{ActorGateways}} by interfaces which
> exposes the required methods. The current implementation would then simply
> wrap the method calls in messages and send them via the {{ActorGateway}} to
> the recipient.
> In Flip-6 the {{JobMaster}} could simply implement these interfaces as part
> of their RPC contract.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
