XComp merged PR #183:
URL: https://github.com/apache/flink-docker/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
XComp merged PR #182:
URL: https://github.com/apache/flink-docker/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
morazow commented on PR #182:
URL: https://github.com/apache/flink-docker/pull/182#issuecomment-2022958489
Thanks @XComp, I have updated both pull requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
XComp commented on PR #182:
URL: https://github.com/apache/flink-docker/pull/182#issuecomment-2022615283
Ok, ping me when you're done updating PR #183 and PR #184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
morazow commented on PR #182:
URL: https://github.com/apache/flink-docker/pull/182#issuecomment-2021392610
Thanks @XComp for looking into 🙏 I have squashed it as you suggested, fixed.
I will update the other PRs similar to this one tomorrow. Thanks a lot!
--
This is an autom
morazow commented on PR #182:
URL: https://github.com/apache/flink-docker/pull/182#issuecomment-2016815995
@XComp please have a look again. If this looks good, I will backport to
other branches accordingly, thanks 🙏
--
This is an automated message from the Apache Git Service.
To respond
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1536816965
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1511250389
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1509921434
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1509049857
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1509007392
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1508874814
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507732247
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507649411
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507649411
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507649411
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507624836
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507624836
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507558823
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on PR #182:
URL: https://github.com/apache/flink-docker/pull/182#issuecomment-1971075237
Another off-topic point, the tests build and package a job using `mvn
package` command. This step pulls many transitive dependencies. Should we add
GitHub action to cache the mvn jars
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507510265
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507455691
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507455691
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507435445
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507435445
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507435159
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507193846
##
.github/workflows/ci.yml:
##
@@ -17,14 +17,22 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
morazow commented on PR #182:
URL: https://github.com/apache/flink-docker/pull/182#issuecomment-1970626496
Morning @XComp,
I have updated the PR accordingly. I had to set the `max-parallel` job to 1,
otherwise the occasionally the docker container names (jobmanager or
taskmanager) wo
morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1506657180
##
.github/workflows/ci.yml:
##
@@ -17,18 +17,19 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SN
morazow commented on PR #182:
URL: https://github.com/apache/flink-docker/pull/182#issuecomment-1969906057
Thanks @XComp, I'll ping you again once I update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
XComp commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1506104617
##
.github/workflows/ci.yml:
##
@@ -17,18 +17,19 @@ name: "CI"
on: [push, pull_request]
+env:
+ TAR_URL:
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP
31 matches
Mail list logo
