morazow commented on code in PR #182: URL: https://github.com/apache/flink-docker/pull/182#discussion_r1509049857
########## .github/workflows/ci.yml: ########## @@ -17,14 +17,22 @@ name: "CI" on: [push, pull_request] +env: + TAR_URL: "https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAPSHOT-bin-scala_2.12.tgz"; + jobs: ci: + name: CI using JDK ${{ matrix.java_version }} runs-on: ubuntu-latest + strategy: + fail-fast: false + max-parallel: 1 Review Comment: Okay run with `cleanup` (removes docker related resources) disabled in the tests, now there are issues: https://github.com/morazow/flink-docker/actions/runs/8112296736/job/22173221898. But this is expected. The initial issue may be was result of these two test contentions: ``` smoke_test_all_images smoke_test_one_image_non_root ``` Both build image, create docker network, and run test. So maybe there was an issue cleanup from one test to next test within a job. Maybe we could refactor to cleanup method, run it before each test start with idempotent checks. https://github.com/morazow/flink-docker/blob/dev-master/testing/testing_lib.sh#L202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
