XComp commented on code in PR #182: URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507193846
########## .github/workflows/ci.yml: ########## @@ -17,14 +17,22 @@ name: "CI" on: [push, pull_request] +env: + TAR_URL: "https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAPSHOT-bin-scala_2.12.tgz"; + jobs: ci: + name: CI using JDK ${{ matrix.java_version }} runs-on: ubuntu-latest + strategy: + fail-fast: false + max-parallel: 1 + matrix: + java_version: [ 8, 11, 17, 21 ] Review Comment: Can you separate the commit: - [hotfix][ci] Updates actions - [hotfix][ci] Utilize matrix strategy in GHA workflow - [FLINK-34419][docker] Adds JDK17 and JDK21 support ########## .github/workflows/ci.yml: ########## @@ -17,14 +17,22 @@ name: "CI" on: [push, pull_request] +env: + TAR_URL: "https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAPSHOT-bin-scala_2.12.tgz"; + jobs: ci: + name: CI using JDK ${{ matrix.java_version }} runs-on: ubuntu-latest + strategy: + fail-fast: false + max-parallel: 1 Review Comment: > I could change the test scripts to name containers so they don't clash. Please let me know. Sorry, I cannot follow. Where does the name clash? :thinking: Can you elaborate a bit more? And if it's actually like that, we might want to add a comment here that explains why `max-parallel: 1` is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
