morazow commented on code in PR #182:
URL: https://github.com/apache/flink-docker/pull/182#discussion_r1507649411


##########
.github/workflows/ci.yml:
##########
@@ -17,14 +17,22 @@ name: "CI"
 
 on: [push, pull_request]
 
+env:
+  TAR_URL: 
"https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAPSHOT-bin-scala_2.12.tgz";
+
 jobs:
   ci:
+    name: CI using JDK ${{ matrix.java_version }}
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      max-parallel: 1

Review Comment:
   Read about the GHA concurrency: 
https://docs.github.com/en/actions/using-jobs/using-concurrency#using-concurrency-in-different-scenarios
   
   My assumption is that I pushed another commit while another workflow was 
running and maybe they clashed on container name.
   
   I would suggest to add concurrency definition to our matrix builds:
   
   ```
   concurrency:
         group: ${{ github.workflow }}-${{ github.ref }}-java-${{ 
matrix.java_version }}
         cancel-in-progress: true
   ```
   
   This way if commits pushed one after the other only the last commit will run 
the workflow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to