morazow commented on code in PR #182: URL: https://github.com/apache/flink-docker/pull/182#discussion_r1509921434
########## .github/workflows/ci.yml: ########## @@ -17,14 +17,22 @@ name: "CI" on: [push, pull_request] +env: + TAR_URL: "https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAPSHOT-bin-scala_2.12.tgz"; + jobs: ci: + name: CI using JDK ${{ matrix.java_version }} runs-on: ubuntu-latest + strategy: + fail-fast: false + max-parallel: 1 Review Comment: I would suggest to change the testing script, I will update with another commit. With matrix strategy, we'll have only one docker file, these scripts check all the docker files. https://github.com/morazow/flink-docker/blob/dev-master/testing/testing_lib.sh#L226-L242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
