Re: [PR] [FLINK-36634][table] Introduce AdaptiveJoinOperator to support dynamic generate join operator at runtime. [flink]

2024-12-23 Thread via GitHub
zhuzhurk commented on code in PR #25593: URL: https://github.com/apache/flink/pull/25593#discussion_r1896476697 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/adaptive/AdaptiveJoin.java: ## @@ -44,30 +43,17 @@ public interface Adap

Re: [PR] [FLINK-36957][Datastream] Implement asyc stream flatmap [flink]

2024-12-23 Thread via GitHub
flinkbot commented on PR #25848: URL: https://github.com/apache/flink/pull/25848#issuecomment-2560713016 ## CI report: * 6359b8e2202b8d54812ae0fd8cf9a961eefed05a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-23 Thread via GitHub
JunRuiLee commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1896440540 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -273,6 +273,14 @@ public void onNewJobVerticesAdded

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-23 Thread via GitHub
JunRuiLee commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1896440135 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResult.java: ## @@ -207,6 +210,10 @@ public boolean isForward() { return i

[jira] [Updated] (FLINK-36957) Implement async StreamFlatMap

2024-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36957: --- Labels: pull-request-available (was: ) > Implement async StreamFlatMap > --

[PR] [FLINK-36957][Datastream] Implement asyc stream flatmap [flink]

2024-12-23 Thread via GitHub
fredia opened a new pull request, #25848: URL: https://github.com/apache/flink/pull/25848 ## What is the purpose of the change This PR implements the asyc version of stream flatmap. ## Brief change log - Introduce `StreamFlatMapAsync` - Update the behavior of

Re: [PR] [FLINK-36763 / 36690][runtime] Support new "distributed" schema evolution topology & fix parallelized hang glitch [flink-cdc]

2024-12-23 Thread via GitHub
leonardBang merged PR #3801: URL: https://github.com/apache/flink-cdc/pull/3801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Assigned] (FLINK-36957) Implement async StreamFlatMap

2024-12-23 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei reassigned FLINK-36957: -- Assignee: Yanfei Lei > Implement async StreamFlatMap > - > >

[jira] [Created] (FLINK-36957) Implement async StreamFlatMap

2024-12-23 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-36957: -- Summary: Implement async StreamFlatMap Key: FLINK-36957 URL: https://issues.apache.org/jira/browse/FLINK-36957 Project: Flink Issue Type: Sub-task Re

Re: [PR] [FLINK-36575][runtime] ExecutionVertexInputInfo supports consuming subpartition groups [flink]

2024-12-23 Thread via GitHub
noorall commented on code in PR #25551: URL: https://github.com/apache/flink/pull/25551#discussion_r1896415395 ## flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory.java: ## @@ -398,6 +403,35 @@ private static boolean isProducerFaile

Re: [PR] [FLINK-36904][BP-1.20] Fix document error on how to programmatically configure serialization [flink]

2024-12-23 Thread via GitHub
X-czh commented on code in PR #25799: URL: https://github.com/apache/flink/pull/25799#discussion_r1896401652 ## docs/content/docs/dev/datastream/fault-tolerance/serialization/third_party_serializers.md: ## @@ -45,8 +45,8 @@ You could also programmatically set it as follows: Con

[jira] [Created] (FLINK-36956) Pipeline transform should deduce PK column types to be NOT NULL

2024-12-23 Thread yux (Jira)
yux created FLINK-36956: --- Summary: Pipeline transform should deduce PK column types to be NOT NULL Key: FLINK-36956 URL: https://issues.apache.org/jira/browse/FLINK-36956 Project: Flink Issue Type: Bu

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-23 Thread via GitHub
JunRuiLee commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1896354071 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -937,6 +965,26 @@ SpeculativeExecutionHandler getS

Re: [PR] [FLINK-36913][pipeline-connector][kafka] Add sink.table.mapping option to allow user to define a custom map for upstream TableId to downstream topic name. [flink-cdc]

2024-12-23 Thread via GitHub
lvyanquan commented on PR #3805: URL: https://github.com/apache/flink-cdc/pull/3805#issuecomment-2560600606 Hi @leonardBang @ruanhang1993, can you help to trigger CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-36877][pipeline-connector-kafka] Fix the output of canal-json for Kafka Sink when the record is deleted record. [flink-cdc]

2024-12-23 Thread via GitHub
lvyanquan commented on PR #3788: URL: https://github.com/apache/flink-cdc/pull/3788#issuecomment-2560598872 The failure of test case is in postgres connector, and is not related with current pr. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-36955][table] Migrate RewriteIntersectAllRule to java [flink]

2024-12-23 Thread via GitHub
flinkbot commented on PR #25847: URL: https://github.com/apache/flink/pull/25847#issuecomment-2560592814 ## CI report: * 3373d7088d845ef00dbe61750d71ca7d0968d95b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36955) Migrate RewriteIntersectAllRule

2024-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36955: --- Labels: pull-request-available (was: ) > Migrate RewriteIntersectAllRule >

[PR] [FLINK-36955][table] Migrate RewriteIntersectAllRule to java [flink]

2024-12-23 Thread via GitHub
liuyongvs opened a new pull request, #25847: URL: https://github.com/apache/flink/pull/25847 ## What is the purpose of the change The PR migrates RewriteIntersectAllRule to java ## Verifying this change This change is already covered by existing tests ## Does this

[jira] [Created] (FLINK-36955) Migrate RewriteIntersectAllRule

2024-12-23 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-36955: - Summary: Migrate RewriteIntersectAllRule Key: FLINK-36955 URL: https://issues.apache.org/jira/browse/FLINK-36955 Project: Flink Issue Type: Sub-task Comp

Re: [PR] [FLINK-36954][table] Migrate CalcRankTransposeRule to java [flink]

2024-12-23 Thread via GitHub
flinkbot commented on PR #25846: URL: https://github.com/apache/flink/pull/25846#issuecomment-2560569242 ## CI report: * 8ea9dc0501e89c82bace572ea6a102b2550fff39 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36954][table] Migrate CalcRankTransposeRule to java [flink]

2024-12-23 Thread via GitHub
liuyongvs commented on code in PR #25846: URL: https://github.com/apache/flink/pull/25846#discussion_r1896298077 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala: ## @@ -399,15 +400,14 @@ object FlinkRexUtil { * @

[jira] [Updated] (FLINK-36954) Migrate CalcRankTransposeRule

2024-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36954: --- Labels: pull-request-available (was: ) > Migrate CalcRankTransposeRule > --

[PR] [FLINK-36954][table] Migrate CalcRankTransposeRule to java [flink]

2024-12-23 Thread via GitHub
liuyongvs opened a new pull request, #25846: URL: https://github.com/apache/flink/pull/25846 ## What is the purpose of the change The PR migrates CalcRankTransposeRule to java ## Verifying this change This change is already covered by existing tests ## Does this pu

[jira] [Created] (FLINK-36954) Migrate CalcRankTransposeRule

2024-12-23 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-36954: - Summary: Migrate CalcRankTransposeRule Key: FLINK-36954 URL: https://issues.apache.org/jira/browse/FLINK-36954 Project: Flink Issue Type: Sub-task Compon

Re: [PR] [FLINK-36952][hotfix][mongodb]Fix MongoDB connector Chinese documentation [flink-cdc]

2024-12-23 Thread via GitHub
Thorne-coder commented on PR #3811: URL: https://github.com/apache/flink-cdc/pull/3811#issuecomment-2560540940 @Jiabao-Sun @yuxiqian PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-36951][table] Migrate ProjectSemiAntiJoinTransposeRule to java [flink]

2024-12-23 Thread via GitHub
liuyongvs commented on PR #25844: URL: https://github.com/apache/flink/pull/25844#issuecomment-2560524801 hi @snuyanzin will you help to review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
JunRuiLee commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1896258796 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java: ## @@ -153,6 +159,8 @@ public ArchivedExecutionGraph( thi

Re: [PR] [hotfix][postgres] Flink CDC Postgres Connector subsribe regular expr… [flink-cdc]

2024-12-23 Thread via GitHub
hql0312 commented on code in PR #3808: URL: https://github.com/apache/flink-cdc/pull/3808#discussion_r1896213233 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/CustomPostgresSchema.java: #

Re: [PR] [hotfix][postgres] Flink CDC Postgres Connector subsribe regular expr… [flink-cdc]

2024-12-23 Thread via GitHub
hql0312 commented on code in PR #3808: URL: https://github.com/apache/flink-cdc/pull/3808#discussion_r1896213233 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/CustomPostgresSchema.java: #

Re: [PR] [hotfix][postgres] Flink CDC Postgres Connector subsribe regular expr… [flink-cdc]

2024-12-23 Thread via GitHub
hql0312 commented on code in PR #3808: URL: https://github.com/apache/flink-cdc/pull/3808#discussion_r1896213233 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/CustomPostgresSchema.java: #

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2024-12-23 Thread via GitHub
snuyanzin commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1896151982 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java: ## @@ -1542,6 +1542,21 @@ void testUsingAddJar

Re: [PR] [FLINK-36429] [runtime-web] Enhancing Flink History Server File Storage and Retrieval with RocksDB [flink]

2024-12-23 Thread via GitHub
venkata91 commented on PR #25838: URL: https://github.com/apache/flink/pull/25838#issuecomment-2560253701 @Shawnsuun There are test failures, can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-36953) FLIP-497: Early Fire Support for Flink SQL Interval Join

2024-12-23 Thread Weiqing Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weiqing Yang updated FLINK-36953: - Fix Version/s: 2.0.0 1.16.3 > FLIP-497: Early Fire Support for Flink SQL Inte

[jira] [Created] (FLINK-36953) FLIP-497: Early Fire Support for Flink SQL Interval Join

2024-12-23 Thread Weiqing Yang (Jira)
Weiqing Yang created FLINK-36953: Summary: FLIP-497: Early Fire Support for Flink SQL Interval Join Key: FLINK-36953 URL: https://issues.apache.org/jira/browse/FLINK-36953 Project: Flink Issu

Re: [PR] [FLINK-36770] make AWS sink writers use ResultHandler, move flink version to 1.20 [flink-connector-aws]

2024-12-23 Thread via GitHub
vahmed-hamdy commented on PR #186: URL: https://github.com/apache/flink-connector-aws/pull/186#issuecomment-2560137187 @hlteoh37 could you have a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
yuchen-ecnu commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895904413 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java: ## @@ -79,6 +79,10 @@ public class JobDetailsInfo implements Response

[jira] [Updated] (FLINK-36931) FlinkCDC YAML supports synchronizing the full amount of data of the entire database in Batch mode

2024-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36931: --- Labels: pull-request-available (was: ) > FlinkCDC YAML supports synchronizing the full amou

[PR] [FLINK-36931][cdc] FlinkCDC YAML supports batch mode [flink-cdc]

2024-12-23 Thread via GitHub
aiwenmo opened a new pull request, #3812: URL: https://github.com/apache/flink-cdc/pull/3812 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
yuchen-ecnu commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895897637 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/DefaultStreamGraphContext.java: ## @@ -69,16 +69,33 @@ public class DefaultStreamGraphContext im

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
yuchen-ecnu commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895897488 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonGeneratorTest.java: ## @@ -151,4 +160,55 @@ private void checkVertexExists(String vert

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
yuchen-ecnu commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895896922 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/DefaultStreamGraphContext.java: ## @@ -69,16 +69,33 @@ public class DefaultStreamGraphContext im

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
yuchen-ecnu commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895897313 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonGeneratorTest.java: ## @@ -151,4 +160,55 @@ private void checkVertexExists(String vert

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
yuchen-ecnu commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895897137 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/StreamGraphJsonSchema.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
yuchen-ecnu commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895896784 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobDetailsHandler.java: ## @@ -141,6 +142,11 @@ private static JobDetailsInfo createJobDeta

Re: [PR] Update NFA.java [flink]

2024-12-23 Thread via GitHub
flinkbot commented on PR #25845: URL: https://github.com/apache/flink/pull/25845#issuecomment-2559747422 ## CI report: * a813b91bc24b0bd24f13c4b209cf0864d35d9305 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Update NFA.java [flink]

2024-12-23 Thread via GitHub
melodylx666 opened a new pull request, #25845: URL: https://github.com/apache/flink/pull/25845 ## What is the purpose of the change Modify the correct usage to @link to ensure correct method references ## Brief change log - Modify the reference to the correc

[jira] [Commented] (FLINK-36949) Make getCurrentKey of async state operators return the ground truth

2024-12-23 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907851#comment-17907851 ] Zakelly Lan commented on FLINK-36949: - Merge f8014b6 into master > Make getCurrentK

[jira] [Closed] (FLINK-36949) Make getCurrentKey of async state operators return the ground truth

2024-12-23 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan closed FLINK-36949. --- Resolution: Fixed > Make getCurrentKey of async state operators return the ground truth > --

Re: [PR] [FLINK-36949] Make getCurrentKey of async state operators return the ground truth [flink]

2024-12-23 Thread via GitHub
Zakelly merged PR #25841: URL: https://github.com/apache/flink/pull/25841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Resolved] (FLINK-36944) Introduce 'enableAsycState' in KeyedStream interfaces

2024-12-23 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-36944. - Resolution: Fixed > Introduce 'enableAsycState' in KeyedStream interfaces >

[jira] [Commented] (FLINK-36944) Introduce 'enableAsycState' in KeyedStream interfaces

2024-12-23 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907846#comment-17907846 ] Zakelly Lan commented on FLINK-36944: - Merge 2904c4c2...5b655399 into master > Intr

Re: [PR] [FLINK-36575][runtime] ExecutionVertexInputInfo supports consuming subpartition groups [flink]

2024-12-23 Thread via GitHub
zhuzhurk commented on code in PR #25551: URL: https://github.com/apache/flink/pull/25551#discussion_r1895666240 ## flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ConsumedSubpartitionContext.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [FLINK-36944][DataStream/API] Introduce 'enableAsycState' in KeyedStream interfaces and implement reduce operator [flink]

2024-12-23 Thread via GitHub
Zakelly merged PR #25831: URL: https://github.com/apache/flink/pull/25831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-36944][DataStream/API] Introduce 'enableAsycState' in KeyedStream interfaces and implement reduce operator [flink]

2024-12-23 Thread via GitHub
Zakelly commented on PR #25831: URL: https://github.com/apache/flink/pull/25831#issuecomment-2559552085 Thanks for the review, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-36935][state/forst] Implement fast link for ForStFileSystem [flink]

2024-12-23 Thread via GitHub
fredia commented on code in PR #25818: URL: https://github.com/apache/flink/pull/25818#discussion_r1895661378 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -340,8 +373,9 @@ public boolean delete(Pa

Re: [PR] [FLINK-36763 / 36690][runtime] Support new "distributed" schema evolution topology & fix parallelized hang glitch [flink-cdc]

2024-12-23 Thread via GitHub
yuxiqian commented on PR #3801: URL: https://github.com/apache/flink-cdc/pull/3801#issuecomment-2559530509 Done, fixed and reorganized commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-36949] Make getCurrentKey of async state operators return the ground truth [flink]

2024-12-23 Thread via GitHub
Zakelly commented on PR #25841: URL: https://github.com/apache/flink/pull/25841#issuecomment-2559528075 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36935][state/forst] Implement fast link for ForStFileSystem [flink]

2024-12-23 Thread via GitHub
Zakelly commented on code in PR #25818: URL: https://github.com/apache/flink/pull/25818#discussion_r1895650983 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -340,8 +373,9 @@ public boolean delete(P

Re: [PR] [hotfix][postgres] Flink CDC Postgres Connector subsribe regular expr… [flink-cdc]

2024-12-23 Thread via GitHub
loserwang1024 commented on code in PR #3808: URL: https://github.com/apache/flink-cdc/pull/3808#discussion_r1895650151 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/CustomPostgresSchema.j

Re: [PR] [FLINK-36950][table] Migrate WindowPropertiesRules to java [flink]

2024-12-23 Thread via GitHub
liuyongvs commented on PR #25843: URL: https://github.com/apache/flink/pull/25843#issuecomment-2559513459 hi @snuyanzin will you help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
zhuzhurk commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895616643 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java: ## @@ -79,6 +79,10 @@ public class JobDetailsInfo implements ResponseBod

Re: [PR] [FLINK-36763 / 36690][runtime] Support new "distributed" schema evolution topology & fix parallelized hang glitch [flink-cdc]

2024-12-23 Thread via GitHub
yuxiqian commented on code in PR #3801: URL: https://github.com/apache/flink-cdc/pull/3801#discussion_r1895591572 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/source/DataSource.java: ## @@ -36,4 +37,18 @@ public interface DataSource { default SupportedMetad

Re: [PR] [FLINK-36763 / 36690][runtime] Support new "distributed" schema evolution topology & fix parallelized hang glitch [flink-cdc]

2024-12-23 Thread via GitHub
leonardBang commented on code in PR #3801: URL: https://github.com/apache/flink-cdc/pull/3801#discussion_r1895561549 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/source/DataSource.java: ## @@ -36,4 +37,18 @@ public interface DataSource { default SupportedMe

[jira] [Updated] (FLINK-36952) Fix MongoDB connector Chinese documentation

2024-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36952: --- Labels: pull-request-available (was: ) > Fix MongoDB connector Chinese documentation >

[jira] [Updated] (FLINK-36952) Fix MongoDB connector Chinese documentation

2024-12-23 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorne updated FLINK-36952: --- Summary: Fix MongoDB connector Chinese documentation (was: Fix mongodb connector chinese doc) > Fix MongoD

[jira] [Updated] (FLINK-36952) Fix mongodb connector chinese doc

2024-12-23 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorne updated FLINK-36952: --- Summary: Fix mongodb connector chinese doc (was: Fix mongodb chinese doc) > Fix mongodb connector chinese d

[jira] [Updated] (FLINK-36952) Fix mongodb chinese doc

2024-12-23 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorne updated FLINK-36952: --- Summary: Fix mongodb chinese doc (was: fix mongodb chinese doc) > Fix mongodb chinese doc > ---

[jira] [Commented] (FLINK-36952) fix mongodb chinese doc

2024-12-23 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907808#comment-17907808 ] Thorne commented on FLINK-36952: I will fix it > fix mongodb chinese doc >

[jira] [Created] (FLINK-36952) fix mongodb chinese doc

2024-12-23 Thread Thorne (Jira)
Thorne created FLINK-36952: -- Summary: fix mongodb chinese doc Key: FLINK-36952 URL: https://issues.apache.org/jira/browse/FLINK-36952 Project: Flink Issue Type: Improvement Components: Fli

Re: [PR] [FLINK-36935][state/forst] Implement fast link for ForStFileSystem [flink]

2024-12-23 Thread via GitHub
fredia commented on code in PR #25818: URL: https://github.com/apache/flink/pull/25818#discussion_r1895530114 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/filemapping/FileMappingManager.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed

Re: [PR] [FLINK-36935][state/forst] Implement fast link for ForStFileSystem [flink]

2024-12-23 Thread via GitHub
fredia commented on code in PR #25818: URL: https://github.com/apache/flink/pull/25818#discussion_r1895529234 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/filemapping/FileMappingManager.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed

Re: [PR] Flink 36798 [flink-cdc]

2024-12-23 Thread via GitHub
leonardBang commented on PR #3779: URL: https://github.com/apache/flink-cdc/pull/3779#issuecomment-2559290666 @rodeo-rider Thanks for the contribution, Could you add some test for your optimization? @ruanhang1993 Would you like to help review this PR? -- This is an automated message f

[jira] [Comment Edited] (FLINK-34558) Add RocksDB key/value size metrics

2024-12-23 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907779#comment-17907779 ] Jufang He edited comment on FLINK-34558 at 12/23/24 9:25 AM: -

Re: [PR] [docs] Fix ToC to include H1 [flink-cdc]

2024-12-23 Thread via GitHub
leonardBang merged PR #3773: URL: https://github.com/apache/flink-cdc/pull/3773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[PR] fix DynamicKafkaRecordSerializationSchema, add serialVersionUID [flink-connector-kafka]

2024-12-23 Thread via GitHub
lwjhn opened a new pull request, #143: URL: https://github.com/apache/flink-connector-kafka/pull/143 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] fix DynamicKafkaRecordSerializationSchema, add serialVersionUID [flink-connector-kafka]

2024-12-23 Thread via GitHub
lwjhn commented on PR #143: URL: https://github.com/apache/flink-connector-kafka/pull/143#issuecomment-2559250929 Caused by: java.io.InvalidClassException: org.apache.flink.streaming.connectors.kafka.table.DynamicKafkaRecordSerializationSchema; local class incompatible: stream classdesc se

Re: [PR] fix DynamicKafkaRecordSerializationSchema, add serialVersionUID [flink-connector-kafka]

2024-12-23 Thread via GitHub
boring-cyborg[bot] commented on PR #143: URL: https://github.com/apache/flink-connector-kafka/pull/143#issuecomment-2559250553 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

Re: [PR] [FLINK-36913][pipeline-connector][kafka] Add sink.table.mapping option to allow user to define a custom map for upstream TableId to downstream topic name. [flink-cdc]

2024-12-23 Thread via GitHub
yuxiqian commented on code in PR #3805: URL: https://github.com/apache/flink-cdc/pull/3805#discussion_r1895492708 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/java/org/apache/flink/cdc/connectors/kafka/sink/KafkaDataSinkITCase.java:

Re: [PR] [hotfix][postgres] Flink CDC Postgres Connector subsribe regular expr… [flink-cdc]

2024-12-23 Thread via GitHub
hql0312 commented on PR #3808: URL: https://github.com/apache/flink-cdc/pull/3808#issuecomment-2559230837 @leonardBang @yuxiqian review please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [FLINK-36069][runtime/rest] Extending job detail rest API to expose json stream graph [flink]

2024-12-23 Thread via GitHub
JunRuiLee commented on code in PR #25798: URL: https://github.com/apache/flink/pull/25798#discussion_r1895474609 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java: ## @@ -113,6 +113,10 @@ public class ArchivedExecutionGraph implem

Re: [PR] [FLINK-36935][state/forst] Implement fast link for ForStFileSystem [flink]

2024-12-23 Thread via GitHub
Zakelly commented on code in PR #25818: URL: https://github.com/apache/flink/pull/25818#discussion_r1895442486 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/filemapping/FileMappingManager.java: ## @@ -0,0 +1,148 @@ +/* + * License

Re: [PR] [FLINK-36935][state/forst] Implement fast link for ForStFileSystem [flink]

2024-12-23 Thread via GitHub
Zakelly commented on code in PR #25818: URL: https://github.com/apache/flink/pull/25818#discussion_r1895442486 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/filemapping/FileMappingManager.java: ## @@ -0,0 +1,148 @@ +/* + * License

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-23 Thread via GitHub
JunRuiLee commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1895392487 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AbstractBlockingResultInfo.java: ## @@ -72,4 +75,9 @@ public void resetPartitionInfo(i

Re: [PR] [FLINK-36067][runtime] Support optimize stream graph based on input info. [flink]

2024-12-23 Thread via GitHub
JunRuiLee commented on code in PR #25790: URL: https://github.com/apache/flink/pull/25790#discussion_r1895383469 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AllToAllBlockingResultInfo.java: ## @@ -139,7 +153,14 @@ public void resetPartitionInf

Re: [PR] [FLINK-34505][table] Migrate WindowGroupReorderRule to java. [flink]

2024-12-23 Thread via GitHub
liuyongvs commented on PR #24375: URL: https://github.com/apache/flink/pull/24375#issuecomment-2559105631 hi @snuyanzin ci passed, will you look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g