JunRuiLee commented on code in PR #25790:
URL: https://github.com/apache/flink/pull/25790#discussion_r1896440135
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResult.java:
##########
@@ -207,6 +210,10 @@ public boolean isForward() {
return intermediateDataSet.isForward();
}
+ public boolean isEveryConsumerConsumeAllSubPartitions() {
Review Comment:
Yes, it was indeed confusing before to have both 'broadcast' and
'EveryConsumerConsumeAllSubPartitions' present at the same time.
Let me explain the reason for introducing this: `Broadcast` used to
represent two specific modes for reading and writing. The writing required
`single subpartition contains all data`, and the reading corresponded to
`consuming the first subpartition (or any single subpartition)`.
Now, I am completely replacing `broadcast` with
`EveryConsumerConsumeAllSubPartitions` and `singleSubpartitionContainsAllData`.
If `singleSubpartitionContainsAllData` is true, then the downstream will only
read the first subpartition. Otherwise, we will check if
`everyConsumerConsumeAllSubPartitions` is true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
