zhuzhurk commented on code in PR #25798:
URL: https://github.com/apache/flink/pull/25798#discussion_r1895616643
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java:
##########
@@ -79,6 +79,10 @@ public class JobDetailsInfo implements ResponseBody {
public static final String FIELD_NAME_JSON_PLAN = "plan";
+ public static final String FIELD_NAME_STREAM_GRAPH_JSON_PLAN =
"stream-graph-plan";
Review Comment:
Could you add some comments to describe its structure?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java:
##########
@@ -79,6 +79,10 @@ public class JobDetailsInfo implements ResponseBody {
public static final String FIELD_NAME_JSON_PLAN = "plan";
+ public static final String FIELD_NAME_STREAM_GRAPH_JSON_PLAN =
"stream-graph-plan";
Review Comment:
Maybe name it directly as `stream-graph` to avoid the redundant `plan`.
StreamGraph already indicates it is a plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
