noorall commented on code in PR #25551:
URL: https://github.com/apache/flink/pull/25551#discussion_r1896415395


##########
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory.java:
##########
@@ -398,6 +403,35 @@ private static boolean 
isProducerFailedOrCanceled(ExecutionState producerState)
                 || producerState == ExecutionState.FAILED;
     }
 
+    private Map<IndexRange, IndexRange> 
constructConsumedSubpartitionGroupByChannelRange(

Review Comment:
   > It's better to add some comments to describe what this method does, and 
why we need to do this conversion.
   
   It's a useless method, I will remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to