snuyanzin commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1896151982
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1542,6 +1542,21 @@ void testUsingAddJar() throws Exception {
"drop function lowerUdf");
}
+ @Test
+ void testUsingAddJarWithCheckpointing() throws Exception {
+ env().enableCheckpointing(100);
+ tEnv().executeSql(String.format("ADD JAR '%s'", jarPath));
+ ClassLoader contextClassLoader =
Thread.currentThread().getContextClassLoader();
+ testUserDefinedFunctionByUsingJar(
+ env ->
+ env.executeSql(
+ String.format(
+ "create function lowerUdf as '%s'
LANGUAGE JAVA",
+ udfClassName)),
+ "drop function lowerUdf");
+
assertThat(contextClassLoader.equals(Thread.currentThread().getContextClassLoader()));
+ }
Review Comment:
I'm still puzzled why we are going here in different direction in compare
with master branch where same code for TableEnvironmentImpl was not change and
the problem is solved. Having this in mind I'm not sure this approach the
correct one...
>I assume this issue fix in 2.0 is a side effect of the refactoring and not
a direct fix.
Did you do git bisect or on what is this assumption based? I'm asking since
I haven't found any confirmation that this issue was fixed by exactly commits
within [FLINK-36065](https://issues.apache.org/jira/browse/FLINK-36065)
Also it would be great to get some responses for the comment at
https://github.com/apache/flink/pull/25656#discussion_r1894239482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
