fredia commented on code in PR #25818: URL: https://github.com/apache/flink/pull/25818#discussion_r1895661378
########## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ########## @@ -340,8 +373,9 @@ public boolean delete(Path path, boolean recursive) throws IOException { if (localPathTuple.f0) { success = localFS.delete(localPathTuple.f1, recursive); // delete from local } - success |= delegateFS.delete(path, recursive); // and delete from remote + success |= fileMappingManager.deleteFile(path, recursive); Review Comment: Currently, files built by `create` won't be put into `fileMapping` hash map. `fileMappingManager.deleteFile` would delete the files not in `filemapping` directly. I will change the description of `FileMappingManager`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org