Re: [PR] [BP-1.20][FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
XComp commented on code in PR #25767: URL: https://github.com/apache/flink/pull/25767#discussion_r1877524296 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -1246,6 +1269,73 @@ private void testNonBlockingCall(

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2530712292 again >and also it was discussed at https://issues.apache.org/jira/browse/FLINK-36181#comment-17878101 please join discussion there -- This is an automated message from the

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-09 Thread via GitHub
pan3793 commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2530706283 > I don't think that this PR which has different target I think the purpose of upgrading is to use a modern scala version to gain modern Java version compatibility, upgrading from s

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2530689681 then I would suggest to ask a question in ML or create a jira issue I don't think that this PR which has different target is the best place to dicuss it -- This is an automated mes

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-09 Thread via GitHub
pan3793 commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2530679239 @snuyanzin the approach you mentioned requires the user to modify the Flink installation, this is not allowed for some managed env > `rm flink-dist/lib/flink-scala*` -- This is a

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2530662410 @pan3793 have you seen this https://flink.apache.org/2022/02/22/scala-free-in-one-fifteen/ ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-34973][runtime] Complete timer before emitting watermark [flink]

2024-12-09 Thread via GitHub
flinkbot commented on PR #25773: URL: https://github.com/apache/flink/pull/25773#issuecomment-2530598280 ## CI report: * e2c3e829a5e0691dc94d5530272aa4787cbbbd69 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36784][common] Support to add metadata columns for data in the meta fields of DataChangeEvent at transform [flink-cdc]

2024-12-09 Thread via GitHub
ruanhang1993 commented on code in PR #3758: URL: https://github.com/apache/flink-cdc/pull/3758#discussion_r1877454617 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformFilterProcessor.java: ## @@ -135,6 +159,19 @@ private Object[] gener

[PR] [FLINK-34973][runtime] Complete timer before emitting watermark [flink]

2024-12-09 Thread via GitHub
fredia opened a new pull request, #25773: URL: https://github.com/apache/flink/pull/25773 ## What is the purpose of the change This PR makes timers completed before emitting watermark. ## Brief change log - Let `advanceWatermark` return `CompletableFuture`.

Re: [PR] [FLINK-36784][common] Support to add metadata columns for data in the meta fields of DataChangeEvent at transform [flink-cdc]

2024-12-09 Thread via GitHub
ruanhang1993 commented on code in PR #3758: URL: https://github.com/apache/flink-cdc/pull/3758#discussion_r1877446250 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformFilterProcessor.java: ## @@ -67,15 +73,22 @@ public static Transform

[jira] [Updated] (FLINK-34973) FLIP-425: Asynchronous Execution Model

2024-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34973: --- Labels: pull-request-available (was: ) > FLIP-425: Asynchronous Execution Model > -

[jira] [Updated] (FLINK-36508) Remove all deprecated methods in `SymbolType `

2024-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36508: --- Labels: pull-request-available (was: ) > Remove all deprecated methods in `SymbolType ` > -

Re: [PR] [FLINK-36508][table-common] Remove all deprecated methods in SymbolType [flink]

2024-12-09 Thread via GitHub
lajith2006 commented on PR #25520: URL: https://github.com/apache/flink/pull/25520#issuecomment-2530593794 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Created] (FLINK-36875) Complete timer before emiting watermark

2024-12-09 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-36875: -- Summary: Complete timer before emiting watermark Key: FLINK-36875 URL: https://issues.apache.org/jira/browse/FLINK-36875 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-09 Thread via GitHub
yiyutian1 commented on code in PR #25752: URL: https://github.com/apache/flink/pull/25752#discussion_r1877429470 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamLogicalOptimizeSelectDistinctRule.scala: ## @@ -0,0

[jira] [Created] (FLINK-36874) KafkaSourceBuilder in pyflink did not implement setDeserializer() method

2024-12-09 Thread Shuyi Chen (Jira)
Shuyi Chen created FLINK-36874: -- Summary: KafkaSourceBuilder in pyflink did not implement setDeserializer() method Key: FLINK-36874 URL: https://issues.apache.org/jira/browse/FLINK-36874 Project: Flink

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-09 Thread via GitHub
1996fanrui commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1877409294 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/validation/DefaultValidatorTest.java: ## @@ -940,13 +958,78 @@ publi

[jira] [Updated] (FLINK-36873) Adapting batch job progress recovery to Apache Celeborn

2024-12-09 Thread xuhuang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuhuang updated FLINK-36873: Description: I've identified several issues while attempting to enable Apache Celeborn to support Flink b

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-09 Thread via GitHub
1996fanrui commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1877406682 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -296,8 +297,14 @@ protected static void computeProc

Re: [PR] [FLINK-36868][State] Provide file system methods with string parameters for ForSt JNI [flink]

2024-12-09 Thread via GitHub
flinkbot commented on PR #25772: URL: https://github.com/apache/flink/pull/25772#issuecomment-2530492661 ## CI report: * bb8bd9cc219b0291c69dc4287e0178de847f8def UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36868][State] Provide file system methods with string parameters for ForSt JNI [flink]

2024-12-09 Thread via GitHub
Zakelly commented on PR #25772: URL: https://github.com/apache/flink/pull/25772#issuecomment-2530469719 Since the `ForSt` `0.1.4-beta` is not released, the CI will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-36868) Provide file system methods with string parameters for ForSt JNI

2024-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36868: --- Labels: pull-request-available (was: ) > Provide file system methods with string parameters

[PR] [FLINK-36868][State] Provide file system methods with string parameters for ForSt JNI [flink]

2024-12-09 Thread via GitHub
Zakelly opened a new pull request, #25772: URL: https://github.com/apache/flink/pull/25772 ## What is the purpose of the change Currently, the ForSt core use `ForStFlinkFileSystem` via JNI to manipulate files. However, the parameter and return value contains `Path`, which introduces

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-09 Thread via GitHub
pan3793 commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2530452174 Both Kafka 4 and Spark 4 drop support for Scala 2.12 and move to Scala 2.13, how far is it from Flink completely removing Scala, to allow downstream projects to use Scala 2.13/3? P

Re: [PR] [FLINK-36484] [TABLE-SQL] Remove deprecated methods StreamTableEnvironment#registerFunction [flink]

2024-12-09 Thread via GitHub
ammu20-dev commented on PR #25529: URL: https://github.com/apache/flink/pull/25529#issuecomment-2530340497 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Created] (FLINK-36873) Adapting batch job progress recovery to Apache Celeborn

2024-12-09 Thread xuhuang (Jira)
xuhuang created FLINK-36873: --- Summary: Adapting batch job progress recovery to Apache Celeborn Key: FLINK-36873 URL: https://issues.apache.org/jira/browse/FLINK-36873 Project: Flink Issue Type: Imp

Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]

2024-12-09 Thread via GitHub
liuyongvs commented on PR #25742: URL: https://github.com/apache/flink/pull/25742#issuecomment-2530191088 hi @snuyanzin i have addressed your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-36791][table] Remove FlinkPruneEmptyRules. [flink]

2024-12-09 Thread via GitHub
liuyongvs commented on PR #25690: URL: https://github.com/apache/flink/pull/25690#issuecomment-2530190111 hi @snuyanzin will you look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (FLINK-36870) Start scale down timer after initial scale up

2024-12-09 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904332#comment-17904332 ] Rui Fan commented on FLINK-36870: - Thanks [~mxm] for creating this Jira and cc. {quote}t

[jira] [Commented] (FLINK-36860) Adjust internal state v2 interface hierarchy

2024-12-09 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904330#comment-17904330 ] Zakelly Lan commented on FLINK-36860: - Merge d282664 and e016051 into master > Adju

[jira] [Resolved] (FLINK-36860) Adjust internal state v2 interface hierarchy

2024-12-09 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-36860. - Resolution: Fixed > Adjust internal state v2 interface hierarchy > -

Re: [PR] [FLINK-36860][State/v2] Make internal list state inherit the internal merging state [flink]

2024-12-09 Thread via GitHub
Zakelly merged PR #25760: URL: https://github.com/apache/flink/pull/25760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] bkbase flink [flink]

2024-12-09 Thread via GitHub
flinkbot commented on PR #25771: URL: https://github.com/apache/flink/pull/25771#issuecomment-2530116776 ## CI report: * 87b80091d646ae36a4b59827c748b291d5d301a6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-12-09 Thread via GitHub
yuanoOo commented on PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2530090932 @ruanhang1993 Please take a look here when you have some free time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] bkbase flink [flink]

2024-12-09 Thread via GitHub
37-pro opened a new pull request, #25771: URL: https://github.com/apache/flink/pull/25771 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[jira] [Created] (FLINK-36872) The standby jobmanager webui cannot view the taskmanager logs

2024-12-09 Thread yuanfenghu (Jira)
yuanfenghu created FLINK-36872: -- Summary: The standby jobmanager webui cannot view the taskmanager logs Key: FLINK-36872 URL: https://issues.apache.org/jira/browse/FLINK-36872 Project: Flink Is

Re: [PR] [WIP][FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-09 Thread via GitHub
flinkbot commented on PR #25770: URL: https://github.com/apache/flink/pull/25770#issuecomment-2529847593 ## CI report: * 723ca4b30b0817890cdd1b4d90fa06fa77826dba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36871) Add internalRescale metrics to distinguish internalRestart Metrics

2024-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36871: --- Labels: pull-request-available (was: ) > Add internalRescale metrics to distinguish interna

[PR] [FLINK-36871] add rescale metrics in scheduler [flink]

2024-12-09 Thread via GitHub
HuangZhenQiu opened a new pull request, #25770: URL: https://github.com/apache/flink/pull/25770 ## What is the purpose of the change Add numRescales metrics in Scheduler to distinguish the restart caused by auto scaler. ## Brief change log - add numRescales metrics in

Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-09 Thread via GitHub
jnh5y commented on PR #25752: URL: https://github.com/apache/flink/pull/25752#issuecomment-2529687242 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-09 Thread via GitHub
yiyutian1 commented on PR #25752: URL: https://github.com/apache/flink/pull/25752#issuecomment-2529584303 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [docs] Fix Apache Avro Specification Link. [flink]

2024-12-09 Thread via GitHub
donPain opened a new pull request, #25769: URL: https://github.com/apache/flink/pull/25769 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [docs] Fix Apache Avro Specification Link. [flink]

2024-12-09 Thread via GitHub
flinkbot commented on PR #25769: URL: https://github.com/apache/flink/pull/25769#issuecomment-2529421981 ## CI report: * 7359a1e9873599ad7fedeeda650b75516be126b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-18704][table] Add DECIMAL type in datagen [flink]

2024-12-09 Thread via GitHub
snuyanzin closed pull request #13154: [FLINK-18704][table] Add DECIMAL type in datagen URL: https://github.com/apache/flink/pull/13154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-36861][table-planner] CREATE TABLE AS with METADATA columns doesn't work [flink]

2024-12-09 Thread via GitHub
spena commented on code in PR #25758: URL: https://github.com/apache/flink/pull/25758#discussion_r1876497296 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -804,6 +804,61 @@ public void testCr

Re: [PR] [FLINK-36861][table-planner] CREATE TABLE AS with METADATA columns doesn't work [flink]

2024-12-09 Thread via GitHub
spena commented on code in PR #25758: URL: https://github.com/apache/flink/pull/25758#discussion_r1876495984 ## tools/maven/suppressions.xml: ## @@ -35,6 +35,7 @@ under the License. + Review Comment: Yeah, we can do that. I move

Re: [PR] [FLINK-36861][table-planner] CREATE TABLE AS with METADATA columns doesn't work [flink]

2024-12-09 Thread via GitHub
spena commented on code in PR #25758: URL: https://github.com/apache/flink/pull/25758#discussion_r1876496585 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/MergeTableAsUtil.java: ## @@ -386,19 +387,24 @@ private void validateImplicitCa

Re: [PR] [FLINK-18704][table] Add DECIMAL type in datagen [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on PR #13154: URL: https://github.com/apache/flink/pull/13154#issuecomment-2529061933 Superseded by https://github.com/apache/flink/pull/13010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-17183][table] support 'create table [if not exists]' syntax [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on PR #11772: URL: https://github.com/apache/flink/pull/11772#issuecomment-2529039747 Superseded by https://github.com/apache/flink/pull/13037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-17183][table] support 'create table [if not exists]' syntax [flink]

2024-12-09 Thread via GitHub
snuyanzin closed pull request #11772: [FLINK-17183][table] support 'create table [if not exists]' syntax URL: https://github.com/apache/flink/pull/11772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [BP-1.20][FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25767: URL: https://github.com/apache/flink/pull/25767#discussion_r1876453346 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -1246,6 +1269,73 @@ private void testNonBlockingCa

Re: [PR] [BP-1.20][FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25767: URL: https://github.com/apache/flink/pull/25767#discussion_r1876453346 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -1246,6 +1269,73 @@ private void testNonBlockingCa

Re: [PR] [BP-1.20][FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
XComp commented on PR #25767: URL: https://github.com/apache/flink/pull/25767#issuecomment-2528837347 I accidentally added JDK11 code in `master` which makes the backports (a bit) trickier. See the fix in [the diff](https://github.com/apache/flink/compare/d402fa093cca3fcf3723d263b1d8a6165f0

Re: [PR] [FLINK-36546] Handle batch sources in DataSinkTranslator [flink-cdc]

2024-12-09 Thread via GitHub
morozov commented on PR #3646: URL: https://github.com/apache/flink-cdc/pull/3646#issuecomment-2528862150 > Hi, @morozov, sorry for my late reply and I've verified you fix and it look good to me, so you can revert the last commit if you want. Thank you! > By the way, the bound

Re: [PR] [FLINK-35857] fix redeploy failed deployment without latest checkpoint [flink-kubernetes-operator]

2024-12-09 Thread via GitHub
jwan666 commented on PR #855: URL: https://github.com/apache/flink-kubernetes-operator/pull/855#issuecomment-2528828517 > > @chenyuzhi459 Can you list all the configurations you have? I have the similar issue (job restart cannot be from checkpoint) and I've tried to use your fix in v1.10.

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876395939 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -432,15 +435,17 @@ private Stream temporalOv

[jira] [Created] (FLINK-36871) Add internalRescale metrics to distinguish internalRestart Metrics

2024-12-09 Thread Zhenqiu Huang (Jira)
Zhenqiu Huang created FLINK-36871: - Summary: Add internalRescale metrics to distinguish internalRestart Metrics Key: FLINK-36871 URL: https://issues.apache.org/jira/browse/FLINK-36871 Project: Flink

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
hanyuzheng7 commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876380102 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -432,15 +435,17 @@ private Stream temporal

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
hanyuzheng7 commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876369119 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -580,10 +585,27 @@ private Stream ceilTest

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
hanyuzheng7 commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876373248 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -580,10 +585,27 @@ private Stream ceilTest

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876371386 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -432,15 +435,17 @@ private Stream temporalOv

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
hanyuzheng7 commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876369119 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -580,10 +585,27 @@ private Stream ceilTest

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
hanyuzheng7 commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876366812 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -432,15 +435,17 @@ private Stream temporal

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876366713 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -580,10 +585,27 @@ private Stream ceilTestCa

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
jnh5y commented on PR #25759: URL: https://github.com/apache/flink/pull/25759#issuecomment-2528771223 Is there any documentation for this function? If it mentions details, we may need to update them. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
jnh5y commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1876356970 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -432,15 +435,17 @@ private Stream temporalOverla

[jira] [Commented] (FLINK-36451) Kubernetes Application JobManager Potential Deadlock and TaskManager Pod Residuals

2024-12-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904215#comment-17904215 ] Matthias Pohl commented on FLINK-36451: --- Fix is merged to {{master}}. I'm preparin

Re: [PR] [BP-1.19][FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
flinkbot commented on PR #25768: URL: https://github.com/apache/flink/pull/25768#issuecomment-2528612027 ## CI report: * b44c671a34cc165ef8223d6a3a29e183ac09980f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.20][FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
flinkbot commented on PR #25767: URL: https://github.com/apache/flink/pull/25767#issuecomment-2528611497 ## CI report: * d402fa093cca3fcf3723d263b1d8a6165f0b35bc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-36870) Start scale down timer after initial scale up

2024-12-09 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904214#comment-17904214 ] Maximilian Michels commented on FLINK-36870: CC [~fanrui] > Start scale dow

[jira] [Created] (FLINK-36870) Start scale down timer after initial scale up

2024-12-09 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-36870: -- Summary: Start scale down timer after initial scale up Key: FLINK-36870 URL: https://issues.apache.org/jira/browse/FLINK-36870 Project: Flink Iss

[PR] [BP-1.20][FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
XComp opened a new pull request, #25767: URL: https://github.com/apache/flink/pull/25767 This is the 1.20 backport of parent PR #25679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
hanyuzheng7 commented on PR #25759: URL: https://github.com/apache/flink/pull/25759#issuecomment-2528561200 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-09 Thread via GitHub
XComp merged PR #25679: URL: https://github.com/apache/flink/pull/25679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
snuyanzin merged PR #25766: URL: https://github.com/apache/flink/pull/25766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ [flink]

2024-12-09 Thread via GitHub
hanyuzheng7 commented on PR #25759: URL: https://github.com/apache/flink/pull/25759#issuecomment-2528489736 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]

2024-12-09 Thread via GitHub
vahmed-hamdy commented on code in PR #113: URL: https://github.com/apache/flink-connector-elasticsearch/pull/113#discussion_r1876236366 ## .github/workflows/weekly.yml: ## @@ -30,27 +30,21 @@ jobs: strategy: matrix: flink_branches: [{ - flink: 1.18

Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]

2024-12-09 Thread via GitHub
dannycranmer commented on code in PR #113: URL: https://github.com/apache/flink-connector-elasticsearch/pull/113#discussion_r1876228825 ## .github/workflows/weekly.yml: ## @@ -30,27 +30,21 @@ jobs: strategy: matrix: flink_branches: [{ - flink: 1.18

[PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]

2024-12-09 Thread via GitHub
vahmed-hamdy opened a new pull request, #113: URL: https://github.com/apache/flink-connector-elasticsearch/pull/113 This ports #110 to branch v3.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [hotfix][Connector/Elasticsearch] Update version to 3.1-SNAPSHOT [flink-connector-elasticsearch]

2024-12-09 Thread via GitHub
dannycranmer merged PR #111: URL: https://github.com/apache/flink-connector-elasticsearch/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

Re: [PR] [hotfix][Connector/Elasticsearch] Update version to 3.1-SNAPSHOT [flink-connector-elasticsearch]

2024-12-09 Thread via GitHub
dannycranmer commented on PR #111: URL: https://github.com/apache/flink-connector-elasticsearch/pull/111#issuecomment-2528321354 > What happened to the CI? :thinking_face: https://github.com/apache/flink-connector-elasticsearch/actions/runs/11690099494/job/32560148880?pr=111 > th

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
davidradl commented on PR #25766: URL: https://github.com/apache/flink/pull/25766#issuecomment-2528271428 CI is failing - it got past the docs test but then failed to complete the step after - so the job was cancelled. I will try again later -- This is an automated message from the Apache

Re: [PR] [FLINK-36861][table-planner] CREATE TABLE AS with METADATA columns doesn't work [flink]

2024-12-09 Thread via GitHub
davidradl commented on code in PR #25758: URL: https://github.com/apache/flink/pull/25758#discussion_r1876140487 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -804,6 +804,61 @@ public void te

Re: [PR] [FLINK-36861][table-planner] CREATE TABLE AS with METADATA columns doesn't work [flink]

2024-12-09 Thread via GitHub
davidradl commented on code in PR #25758: URL: https://github.com/apache/flink/pull/25758#discussion_r1876117885 ## tools/maven/suppressions.xml: ## @@ -35,6 +35,7 @@ under the License. + Review Comment: can we not split this fi

Re: [PR] [FLINK-36861][table-planner] CREATE TABLE AS with METADATA columns doesn't work [flink]

2024-12-09 Thread via GitHub
davidradl commented on code in PR #25758: URL: https://github.com/apache/flink/pull/25758#discussion_r1876128994 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/MergeTableAsUtil.java: ## @@ -386,19 +387,24 @@ private void validateImplic

Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-09 Thread via GitHub
jnh5y commented on PR #25752: URL: https://github.com/apache/flink/pull/25752#issuecomment-2528153153 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
davidradl commented on PR #25766: URL: https://github.com/apache/flink/pull/25766#issuecomment-2528086022 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (FLINK-36830) Override json-path version used by Calcite Bridge

2024-12-09 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-36830: -- Assignee: Thomas Cooper > Override json-path version used by Calcite Bridge > ---

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
davidradl commented on code in PR #25766: URL: https://github.com/apache/flink/pull/25766#discussion_r1876032909 ## docs/content/docs/flinkDev/ide_setup.md: ## @@ -124,7 +124,7 @@ install them, and restart the IDE if prompted: You will also need to install the [google-java-f

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-09 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1876028018 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2332,14 +2332,24 @@ ANY, and(logical(LogicalT

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25766: URL: https://github.com/apache/flink/pull/25766#discussion_r1876023276 ## docs/content/docs/flinkDev/ide_setup.md: ## @@ -124,7 +124,7 @@ install them, and restart the IDE if prompted: You will also need to install the [google-java-f

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
davidradl commented on code in PR #25766: URL: https://github.com/apache/flink/pull/25766#discussion_r1876026898 ## docs/content/docs/flinkDev/ide_setup.md: ## @@ -124,7 +124,7 @@ install them, and restart the IDE if prompted: You will also need to install the [google-java-f

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25766: URL: https://github.com/apache/flink/pull/25766#discussion_r1876023276 ## docs/content/docs/flinkDev/ide_setup.md: ## @@ -124,7 +124,7 @@ install them, and restart the IDE if prompted: You will also need to install the [google-java-f

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25766: URL: https://github.com/apache/flink/pull/25766#discussion_r1876008473 ## docs/content/docs/flinkDev/ide_setup.md: ## @@ -124,13 +124,15 @@ install them, and restart the IDE if prompted: You will also need to install the [google-java

Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]

2024-12-09 Thread via GitHub
snuyanzin commented on code in PR #25766: URL: https://github.com/apache/flink/pull/25766#discussion_r1876008473 ## docs/content/docs/flinkDev/ide_setup.md: ## @@ -124,13 +124,15 @@ install them, and restart the IDE if prompted: You will also need to install the [google-java

[jira] [Updated] (FLINK-36862) Implement additional TO_TIMESTAMP_LTZ() functions

2024-12-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-36862: --- Component/s: Table SQL / API > Implement additional TO_TIMESTAMP_LTZ() functions > -

[jira] [Assigned] (FLINK-36861) CREATE TABLE AS with METADATA columns doesn't work

2024-12-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36861: -- Assignee: Sergio Peña > CREATE TABLE AS with METADATA columns doesn't work >

[jira] [Assigned] (FLINK-36866) Support more CDC YAML numeric casting paths

2024-12-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36866: -- Assignee: yux > Support more CDC YAML numeric casting paths > ---

[jira] [Assigned] (FLINK-36865) Provide UNIX_TIMESTAMP series functions in YAML pipeline

2024-12-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36865: -- Assignee: yux > Provide UNIX_TIMESTAMP series functions in YAML pipeline > --

[jira] [Assigned] (FLINK-36864) YAML Pipeline could not write number literals that exceeds Int32 range

2024-12-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36864: -- Assignee: yux > YAML Pipeline could not write number literals that exceeds Int32 range >

  1   2   >