1996fanrui commented on code in PR #921:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1877406682
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -296,8 +297,14 @@ protected static void computeProcessingRateThresholds(
upperUtilization = 1.0;
lowerUtilization = 0.0;
} else {
- upperUtilization = targetUtilization + utilizationBoundary;
- lowerUtilization = targetUtilization - utilizationBoundary;
+ upperUtilization =
+ conf.getOptional(TARGET_UTILIZATION_BOUNDARY)
+ .map(boundary -> targetUtilization + boundary)
+ .orElseGet(() -> conf.get(UTILIZATION_MAX));
+ lowerUtilization =
+ conf.getOptional(TARGET_UTILIZATION_BOUNDARY)
+ .map(boundary -> targetUtilization - boundary)
+ .orElseGet(() -> conf.get(UTILIZATION_MIN));
}
double scaleUpThreshold =
Review Comment:
> But how does Autoscaler standlone handle exceptions where these parameters
are unreasonable.
by event report?
>
> I'm not sure if it needs to be resolved via another PR?
It's acceptable that Autoscaler standlone check options in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
