1996fanrui commented on code in PR #921:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1877409294
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/validation/DefaultValidatorTest.java:
##########
@@ -940,13 +958,78 @@ public void testNonEnabledAutoScalerSessionJob() {
flinkConf.put(AutoScalerOptions.AUTOSCALER_ENABLED.key(), "false");
flinkConf.put(AutoScalerOptions.MAX_SCALE_DOWN_FACTOR.key(), "-1.6");
flinkConf.put(AutoScalerOptions.MAX_SCALE_UP_FACTOR.key(), "-1.6");
-
flinkConf.put(AutoScalerOptions.TARGET_UTILIZATION.key(), "-1.6");
- flinkConf.put(
-
AutoScalerOptions.TARGET_UTILIZATION_BOUNDARY.key(), "-1.6");
+
flinkConf.put(AutoScalerOptions.UTILIZATION_TARGET.key(), "-1.6");
+
flinkConf.put(AutoScalerOptions.UTILIZATION_MAX.key(), "-1.6");
+
flinkConf.put(AutoScalerOptions.UTILIZATION_MIN.key(), "-1.6");
});
assertErrorNotContains(result);
}
+ @Test
+ public void testAutoScalerConfigurationNumberOrder() {
Review Comment:
If the last comment makes sense, this test needs to be refactored.
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -605,9 +605,16 @@ public static Optional<String>
validateAutoScalerFlinkConfiguration(
return firstPresent(
validateNumber(flinkConfiguration,
AutoScalerOptions.MAX_SCALE_DOWN_FACTOR, 0.0d),
validateNumber(flinkConfiguration,
AutoScalerOptions.MAX_SCALE_UP_FACTOR, 0.0d),
- validateNumber(flinkConfiguration,
AutoScalerOptions.TARGET_UTILIZATION, 0.0d),
+ validateNumber(flinkConfiguration,
AutoScalerOptions.UTILIZATION_TARGET, 0.0d),
validateNumber(
flinkConfiguration,
AutoScalerOptions.TARGET_UTILIZATION_BOUNDARY, 0.0d),
+ validateNumber(flinkConfiguration,
AutoScalerOptions.UTILIZATION_MAX, 0.0d, 1.0d),
+ validateNumber(flinkConfiguration,
AutoScalerOptions.UTILIZATION_MIN, 0.0d, 1.0d),
Review Comment:
It seems we don't need a new `validateNumberOrder`, and following change is
enough.
```suggestion
validateNumber(flinkConfiguration,
AutoScalerOptions.UTILIZATION_MAX,
flinkConfiguration.get(AutoScalerOptions.UTILIZATION_TARGET), 1.0d),
validateNumber(flinkConfiguration,
AutoScalerOptions.UTILIZATION_MIN, 0.0d,
flinkConfiguration.get(AutoScalerOptions.UTILIZATION_TARGET)),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
