snuyanzin commented on code in PR #25766:
URL: https://github.com/apache/flink/pull/25766#discussion_r1876008473


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,13 +124,15 @@ install them, and restart the IDE if prompted:
 
 You will also need to install the 
[google-java-format](https://github.com/google/google-java-format)
 plugin. However, a specific version of this plugin is required. Download
-[google-java-format 
v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format 
v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
 and install it as follows. Make sure to never update this plugin.
 
 1. Go to "Settings" → "Plugins".
 2. Click the gear icon and select "Install Plugin from Disk".
 3. Navigate to the downloaded ZIP file and select it.
 
+Note for flink v1 the required level of 
[google-java-format](https://github.com/google/google-java-format) was  
[google-java-format 
v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+

Review Comment:
   I don't think we need this
   
   every Flink version has its own branch and for each there is a separate doc 
page
   so for 1.x there are already existing pages covering this
   otherwise we will end up with duplicating every change between versions in 
several places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to