snuyanzin commented on code in PR #25759:
URL: https://github.com/apache/flink/pull/25759#discussion_r1876366713
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##########
@@ -580,10 +585,27 @@ private Stream<TestSetSpec> ceilTestCases() {
$("f2").ceil(TimeIntervalUnit.MILLENNIUM),
"CEIL(f2 TO MILLENNIUM)",
LocalDateTime.of(3001, 1, 1, 0, 0),
- TIMESTAMP().nullable()));
+ TIMESTAMP().nullable())
+ .testResult(
+
$("f2").cast(TIMESTAMP_LTZ(3)).ceil(TimeIntervalUnit.MINUTE),
+ "CEIL(CAST(f2 AS TIMESTAMP_LTZ(3)) TO MINUTE)",
+ ZonedDateTime.of(
+ LocalDateTime.of(2020, 2, 29,
1, 57, 0),
+ ZoneId.of("UTC"))
+ .toInstant(),
+ TIMESTAMP_LTZ(3))
+ .testResult(
+
$("f3").cast(TIMESTAMP_LTZ(3)).ceil(TimeIntervalUnit.SECOND),
+ "CEIL(CAST(f3 AS TIMESTAMP_LTZ(3)) TO SECOND)",
+ ZonedDateTime.of(
+ LocalDateTime.of(2020, 2, 29,
1, 56, 58),
+ ZoneId.of("UTC"))
+ .toInstant(),
+ TIMESTAMP_LTZ(3)));
}
private Stream<TestSetSpec> floorTestCases() {
+ TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
Review Comment:
that's weird that we set it for all test cases...
can we set it only for some certain test cases and then unset it back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
