hanyuzheng7 commented on code in PR #25759:
URL: https://github.com/apache/flink/pull/25759#discussion_r1876366812


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##########
@@ -432,15 +435,17 @@ private Stream<TestSetSpec> temporalOverlapsTestCases() {
     }
 
     private Stream<TestSetSpec> ceilTestCases() {
+        TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
         return Stream.of(
                 TestSetSpec.forFunction(BuiltInFunctionDefinitions.FLOOR)
                         .onFieldsWithData(
                                 // 
https://issues.apache.org/jira/browse/FLINK-17224

Review Comment:
   @jnh5y Now, we test TIMESTAMP_TLZ, which means when we do the test, the 
result depend on the the timezone you run the test, so we should fix the 
timezone, so each people can pass these tests in their timezone. If I don't fix 
the time zone, these test can pass in my laptop, but cannot pass in flink ci 
server, because my time zone is different than flink ci server's time zone



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to