Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
fsk119 commented on PR #25739: URL: https://github.com/apache/flink/pull/25739#issuecomment-2519508466 @chn5944 Thanks a lot for your fix! +1 with @JunRuiLee 's point. I think we can use other language to process this situation. I think we should read more design from other communit

[jira] [Commented] (FLINK-36593) Upgrade io.airlift:aircompressor to mitigate CVE

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903216#comment-17903216 ] Sergey Nuyanzin commented on FLINK-36593: - Merged to 1.20 as [4e5ef6695ce226102

Re: [PR] [FLINK-36593][runtime] Upgrade io.airlift:aircompressor to 0.27 [1.20] [flink]

2024-12-04 Thread via GitHub
snuyanzin merged PR #25606: URL: https://github.com/apache/flink/pull/25606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [WIP] Introduce Generalized Watermark for DSv2 [flink]

2024-12-04 Thread via GitHub
MartijnVisser commented on PR #25731: URL: https://github.com/apache/flink/pull/25731#issuecomment-2519475686 @codenohup To which Jira does this PR belong? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]

2024-12-04 Thread via GitHub
snuyanzin commented on PR #25714: URL: https://github.com/apache/flink/pull/25714#issuecomment-2519452414 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-22155][table] EXPLAIN statement should validate insert and query separately [flink]

2024-12-04 Thread via GitHub
fsk119 closed pull request #15986: [FLINK-22155][table] EXPLAIN statement should validate insert and query separately URL: https://github.com/apache/flink/pull/15986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34974][state] Support getOrCreateKeyedState for AsyncKeyedStateBackend [flink]

2024-12-04 Thread via GitHub
flinkbot commented on PR #25745: URL: https://github.com/apache/flink/pull/25745#issuecomment-2519442335 ## CI report: * e79b187242a8555df37efb4427a07f41a5d5714a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34974) FLIP-424: Asynchronous State APIs

2024-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34974: --- Labels: pull-request-available (was: ) > FLIP-424: Asynchronous State APIs > --

[PR] [FLINK-34974][state] Support getOrCreateKeyedState for AsyncKeyedStateBackend [flink]

2024-12-04 Thread via GitHub
fredia opened a new pull request, #25745: URL: https://github.com/apache/flink/pull/25745 ## What is the purpose of the change Support `getOrCreateKeyedState()` and `isSafeToReuseKVState()` for AsyncKeyedStateBackend. ## Brief change log - Add `getOrCreateKe

[jira] [Created] (FLINK-36853) Support getOrCreateKeyedState for AsyncKeyedStateBackend

2024-12-04 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-36853: -- Summary: Support getOrCreateKeyedState for AsyncKeyedStateBackend Key: FLINK-36853 URL: https://issues.apache.org/jira/browse/FLINK-36853 Project: Flink Issue Ty

Re: [PR] [FLINK-xx][table] Algin Calcite Rules. [flink]

2024-12-04 Thread via GitHub
flinkbot commented on PR #25744: URL: https://github.com/apache/flink/pull/25744#issuecomment-2519424227 ## CI report: * 3bec32a78c7224b53086232a48660c9e3aec660e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36072][runtime] Sort-merge shuffle supports accumulating small buffers to reduce network overhead. [flink]

2024-12-04 Thread via GitHub
reswqa commented on code in PR #25738: URL: https://github.com/apache/flink/pull/25738#discussion_r1870538342 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionedFileReader.java: ## @@ -48,7 +51,7 @@ class PartitionedFileReader { private

[PR] [FLINK-xx][table] Algin Calcite Rules. [flink]

2024-12-04 Thread via GitHub
liuyongvs opened a new pull request, #25744: URL: https://github.com/apache/flink/pull/25744 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Commented] (FLINK-36852) Avoid StackOverflowError in Paimon Pipeline sink

2024-12-04 Thread Yanquan Lv (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903198#comment-17903198 ] Yanquan Lv commented on FLINK-36852: I've found the reason of this error, and will t

[jira] [Created] (FLINK-36852) Avoid StackOverflowError in Paimon Pipeline sink

2024-12-04 Thread Yanquan Lv (Jira)
Yanquan Lv created FLINK-36852: -- Summary: Avoid StackOverflowError in Paimon Pipeline sink Key: FLINK-36852 URL: https://issues.apache.org/jira/browse/FLINK-36852 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-36851) Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API

2024-12-04 Thread Wang Qilong (Jira)
Wang Qilong created FLINK-36851: --- Summary: Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API Key: FLINK-36851 URL: https://issues.apache.org/jira/browse/FLINK-36851 Project:

Re: [PR] [FLINK-36849][table] Introduce AppendOnlyFirstNFunction in Rank with Async State API [flink]

2024-12-04 Thread via GitHub
flinkbot commented on PR #25743: URL: https://github.com/apache/flink/pull/25743#issuecomment-2519358232 ## CI report: * 592834a241086e1236a571ef91393907e0b9c032 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-36849) Introduce AppendOnlyFirstNFunction in Rank with Async State API

2024-12-04 Thread Wang Qilong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903194#comment-17903194 ] Wang Qilong commented on FLINK-36849: - I really hope to be responsible for executing

[jira] [Updated] (FLINK-36849) Introduce AppendOnlyFirstNFunction in Rank with Async State API

2024-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36849: --- Labels: pull-request-available (was: ) > Introduce AppendOnlyFirstNFunction in Rank with As

[PR] [FLINK-36849][table] Introduce AppendOnlyFirstNFunction in Rank with Async State API [flink]

2024-12-04 Thread via GitHub
Au-Miner opened a new pull request, #25743: URL: https://github.com/apache/flink/pull/25743 ## What is the purpose of the change Introduce AppendOnlyFirstNFunction in Rank with Async State API. This task is a subsequent update of [FLINK-36825]. Due to the need to merge the pre PR,

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-04 Thread via GitHub
1996fanrui commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1870706024 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -89,21 +89,35 @@ private static ConfigOptions.Opt

[jira] [Assigned] (FLINK-36850) Adapting batch job progress recovery with StreamGraph adaptive optimization

2024-12-04 Thread Junrui Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Lee reassigned FLINK-36850: -- Assignee: Junrui Lee > Adapting batch job progress recovery with StreamGraph adaptive optimiz

[jira] [Created] (FLINK-36850) Adapting batch job progress recovery with StreamGraph adaptive optimization

2024-12-04 Thread Junrui Lee (Jira)
Junrui Lee created FLINK-36850: -- Summary: Adapting batch job progress recovery with StreamGraph adaptive optimization Key: FLINK-36850 URL: https://issues.apache.org/jira/browse/FLINK-36850 Project: Flin

Re: [PR] [cdc-connector][sqlserver]Flink cdc pipeline support sqlserver source [flink-cdc]

2024-12-04 Thread via GitHub
cobolbaby commented on PR #3445: URL: https://github.com/apache/flink-cdc/pull/3445#issuecomment-2519261431 Why is a perfectly good PR being ignored? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [hotfix][config] Do not use deprecated configs in example config.yaml [flink]

2024-12-04 Thread via GitHub
JunRuiLee merged PR #25736: URL: https://github.com/apache/flink/pull/25736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Created] (FLINK-36849) Introduce AppendOnlyFirstNFunction in Rank with Async State API

2024-12-04 Thread xuyang (Jira)
xuyang created FLINK-36849: -- Summary: Introduce AppendOnlyFirstNFunction in Rank with Async State API Key: FLINK-36849 URL: https://issues.apache.org/jira/browse/FLINK-36849 Project: Flink Issue Ty

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-12-04 Thread via GitHub
liuml07 commented on PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#issuecomment-2519226661 Rebasing from `main` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-36679][runtime] Add a metric to track checkpoint _metadata size [flink]

2024-12-04 Thread via GitHub
liuml07 commented on PR #25634: URL: https://github.com/apache/flink/pull/25634#issuecomment-2519221113 Thanks for the feedback! The reason this being a draft is I haven't spend time testing this end to end. Also I was wondering if other folks in community think this is a useful metric as w

Re: [PR] [FLINK-36679][runtime] Add a metric to track checkpoint _metadata size [flink]

2024-12-04 Thread via GitHub
liuml07 commented on code in PR #25634: URL: https://github.com/apache/flink/pull/25634#discussion_r1870664148 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java: ## @@ -93,6 +93,11 @@ public abstract class AbstractCheckpointStats imp

Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]

2024-12-04 Thread via GitHub
flinkbot commented on PR #25742: URL: https://github.com/apache/flink/pull/25742#issuecomment-2519030224 ## CI report: * f35b91ef62bba2251a2aa6c267daa9abe24fff25 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36848) FlinkLimit0RemoveRule can be replaced by PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE because high version calcite has supported

2024-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36848: --- Labels: pull-request-available (was: ) > FlinkLimit0RemoveRule can be replaced by > PruneE

[PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]

2024-12-04 Thread via GitHub
liuyongvs opened a new pull request, #25742: URL: https://github.com/apache/flink/pull/25742 ## What is the purpose of the change A bit reasoning for the change high calcite version has fixed, current calcite version is 1.34 ## Verifying this change This change is alre

[jira] [Updated] (FLINK-36848) FlinkLimit0RemoveRule can be replaced by PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE because high version calcite has supported

2024-12-04 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Lau updated FLINK-36848: -- Description: calcite has supports lots of  > FlinkLimit0RemoveRule can be replaced by > PruneEmptyRul

[jira] [Updated] (FLINK-36848) FlinkLimit0RemoveRule can be replaced by PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE because high version calcite has supported

2024-12-04 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Lau updated FLINK-36848: -- Description: (was: calcite has supports lots of ) > FlinkLimit0RemoveRule can be replaced by > Pr

[jira] [Created] (FLINK-36848) FlinkLimit0RemoveRule can be replaced by PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE because high version calcite has supported

2024-12-04 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-36848: - Summary: FlinkLimit0RemoveRule can be replaced by PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE because high version calcite has supported Key: FLINK-36848 URL: https://issues.apache.org/ji

Re: [PR] [FLINK-36702][sql-gateway] Introduce ScripExecutor to run the script [flink]

2024-12-04 Thread via GitHub
fsk119 commented on code in PR #25700: URL: https://github.com/apache/flink/pull/25700#discussion_r1870570454 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/application/Printer.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-36702][sql-gateway] Introduce ScripExecutor to run the script [flink]

2024-12-04 Thread via GitHub
fsk119 commented on code in PR #25700: URL: https://github.com/apache/flink/pull/25700#discussion_r1870567814 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/application/ScriptExecutor.java: ## @@ -0,0 +1,332 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2024-12-04 Thread via GitHub
simplejason commented on code in PR #25718: URL: https://github.com/apache/flink/pull/25718#discussion_r1870564250 ## flink-runtime-web/web-dashboard/package.json: ## @@ -14,51 +14,50 @@ }, "private": true, "dependencies": { -"@angular/animations": "^14.2.6", -"

Re: [PR] [hotfix][config] Do not use deprecated configs in example config.yaml [flink]

2024-12-04 Thread via GitHub
showuon commented on PR #25736: URL: https://github.com/apache/flink/pull/25736#issuecomment-2518987575 @Zakelly @fredia , could you take a look? I think this should be part of [FLINK-34255](https://issues.apache.org/jira/browse/FLINK-34255) task. Thanks. -- This is an automated message f

[jira] [Commented] (FLINK-36676) Flink CDC SQL Server Connector Missing Data

2024-12-04 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903169#comment-17903169 ] Thorne commented on FLINK-36676: I suggest  that u  can propose a work order in aliyun c

[jira] [Created] (FLINK-36847) Table API toDataStream() cannot be converted to an enum type field

2024-12-04 Thread LuJiang (Jira)
LuJiang created FLINK-36847: --- Summary: Table API toDataStream() cannot be converted to an enum type field Key: FLINK-36847 URL: https://issues.apache.org/jira/browse/FLINK-36847 Project: Flink Is

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-12-04 Thread via GitHub
liuxiao2shf commented on code in PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#discussion_r1870538039 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/test/java/org/apache/flink/cdc/connectors/base/source/MySqlEventDeserializer.java: ## @@ -0,0

Re: [PR] [FLINK-36066][runtime] Introducing the AdaptiveGraphManager component [flink]

2024-12-04 Thread via GitHub
zhuzhurk commented on code in PR #25414: URL: https://github.com/apache/flink/pull/25414#discussion_r1870499542 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -1678,10 +1678,27 @@ public static ResultPartitionType dete

Re: [PR] Handle map and array types binary record data [flink-cdc]

2024-12-04 Thread via GitHub
umeshdangat commented on PR #3434: URL: https://github.com/apache/flink-cdc/pull/3434#issuecomment-2518863198 > I guess that some classes refer to Flink like [BinaryArrayData](https://github.com/apache/flink/blob/b48ccce1ce201ea76e11f089f43e8c115b96a992/flink-table/flink-table-common/src/mai

Re: [PR] [cdc-connector][sqlserver]Flink cdc pipeline support sqlserver source [flink-cdc]

2024-12-04 Thread via GitHub
github-actions[bot] closed pull request #3445: [cdc-connector][sqlserver]Flink cdc pipeline support sqlserver source URL: https://github.com/apache/flink-cdc/pull/3445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [cdc-connector][sqlserver]Flink cdc pipeline support sqlserver source [flink-cdc]

2024-12-04 Thread via GitHub
github-actions[bot] commented on PR #3445: URL: https://github.com/apache/flink-cdc/pull/3445#issuecomment-2518805465 This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encou

Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]

2024-12-04 Thread via GitHub
snuyanzin commented on code in PR #25714: URL: https://github.com/apache/flink/pull/25714#discussion_r1870394479 ## pom.xml: ## @@ -177,7 +177,7 @@ under the License. 10.18.2 Review Comment: removed. >can we remove this comment now we are

[jira] [Resolved] (FLINK-36792) FlinkJoinPushExpressionsRule can be removed because high version calcite has fixed

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36792. - Resolution: Fixed > FlinkJoinPushExpressionsRule can be removed because high version cal

[jira] [Commented] (FLINK-36792) FlinkJoinPushExpressionsRule can be removed because high version calcite has fixed

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903135#comment-17903135 ] Sergey Nuyanzin commented on FLINK-36792: - Merged as [266f3a5699cf9c3c23fc179a4

Re: [PR] [FLINK-36792][table] Remove FlinkJoinPushExpressionsRule. [flink]

2024-12-04 Thread via GitHub
snuyanzin merged PR #25691: URL: https://github.com/apache/flink/pull/25691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[PR] Bump ws and socket.io in /flink-runtime-web/web-dashboard [flink]

2024-12-04 Thread via GitHub
dependabot[bot] opened a new pull request, #25741: URL: https://github.com/apache/flink/pull/25741 Bumps [ws](https://github.com/websockets/ws) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `ws` from 8.11.0 to 8.17.1

Re: [PR] Bump ws and socket.io in /flink-runtime-web/web-dashboard [flink]

2024-12-04 Thread via GitHub
flinkbot commented on PR #25741: URL: https://github.com/apache/flink/pull/25741#issuecomment-2518680292 ## CI report: * a423368668706fc41921a69238e0194281138738 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Bump d3-color, @antv/g-base and d3-interpolate in /flink-runtime-web/web-dashboard [flink]

2024-12-04 Thread via GitHub
dependabot[bot] opened a new pull request, #25740: URL: https://github.com/apache/flink/pull/25740 Bumps [d3-color](https://github.com/d3/d3-color), [@antv/g-base](https://github.com/antvis/util) and [d3-interpolate](https://github.com/d3/d3-interpolate). These dependencies needed to be up

Re: [PR] Bump d3-color, @antv/g-base and d3-interpolate in /flink-runtime-web/web-dashboard [flink]

2024-12-04 Thread via GitHub
MartijnVisser commented on PR #25740: URL: https://github.com/apache/flink/pull/25740#issuecomment-2518674486 @simplejason Any thoughts on this PR? It's generated because of CVEs in the Web UI by Dependabot -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Bump ws and socket.io in /flink-runtime-web/web-dashboard [flink]

2024-12-04 Thread via GitHub
MartijnVisser commented on PR #25741: URL: https://github.com/apache/flink/pull/25741#issuecomment-2518674769 @simplejason Same here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump d3-color, @antv/g-base and d3-interpolate in /flink-runtime-web/web-dashboard [flink]

2024-12-04 Thread via GitHub
flinkbot commented on PR #25740: URL: https://github.com/apache/flink/pull/25740#issuecomment-2518673852 ## CI report: * 7b37646fbf43f1ef747927e66c5b3c1f7eeb7250 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-36689) [UI] Upgrade runtime web Angular framework and associated deps to latest version

2024-12-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-36689. -- Resolution: Fixed Fixed in apache/flink@master - fecb4466b1b8b0a2a213db7a34695c62e9bbabd4 > [

Re: [PR] [FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2024-12-04 Thread via GitHub
MartijnVisser merged PR #25713: URL: https://github.com/apache/flink/pull/25713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Updated] (FLINK-36688) table.optimizer.reuse-source-enabled may cause disordered metadata columns when reading from Kafka.

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36688: Fix Version/s: 2.0.0 > table.optimizer.reuse-source-enabled may cause disordered metadata

[jira] [Resolved] (FLINK-36688) table.optimizer.reuse-source-enabled may cause disordered metadata columns when reading from Kafka.

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36688. - Resolution: Fixed Merged as [5c87afeceffc52d2e0a24cf547bae6eda4075cfe|https://github.co

Re: [PR] [FLINK-36688][table-planner] Sort metadata keys when reusing source [flink]

2024-12-04 Thread via GitHub
snuyanzin merged PR #25681: URL: https://github.com/apache/flink/pull/25681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-36643) Upgrade aws-java-sdk-core to 1.12.779 to fix vulnerability

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36643: Summary: Upgrade aws-java-sdk-core to 1.12.779 to fix vulnerability (was: Upgrade aws-jav

[jira] [Resolved] (FLINK-36643) Upgrade aws-java-sdk-core to 1.12.773+ to fix vulnerability

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36643. - Resolution: Fixed > Upgrade aws-java-sdk-core to 1.12.773+ to fix vulnerability > --

[jira] [Comment Edited] (FLINK-36643) Upgrade aws-java-sdk-core to 1.12.773+ to fix vulnerability

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902045#comment-17902045 ] Sergey Nuyanzin edited comment on FLINK-36643 at 12/4/24 10:01 PM: ---

Re: [PR] [FLINK-36643][filesystems] Update aws-java-sdk-core to 1.12.779 [1.19] [flink]

2024-12-04 Thread via GitHub
snuyanzin merged PR #25719: URL: https://github.com/apache/flink/pull/25719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-36643) Upgrade aws-java-sdk-core to 1.12.773+ to fix vulnerability

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36643: Fix Version/s: 1.19.2 > Upgrade aws-java-sdk-core to 1.12.773+ to fix vulnerability >

[jira] [Commented] (FLINK-36733) Don't transition task to RUNNING until the inputs are recovered (UC)

2024-12-04 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903082#comment-17903082 ] Alexander Fedulov commented on FLINK-36733: --- [~roman] I am working on preparin

Re: [PR] Flink 33387 33388 draft2 for CI [flink]

2024-12-04 Thread via GitHub
RocMarshal closed pull request #25734: Flink 33387 33388 draft2 for CI URL: https://github.com/apache/flink/pull/25734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
chn5944 commented on PR #25739: URL: https://github.com/apache/flink/pull/25739#issuecomment-2517302132 @fsk119 i already report this issue by e-mail and get response from fskm...@gmail.com -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (FLINK-36675) Dynamic option hints will not take effect when restoring exec plan from json plan without setting 'table.plan.compile.catalog-objects' to 'all'

2024-12-04 Thread Thomas Cooper (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903063#comment-17903063 ] Thomas Cooper commented on FLINK-36675: --- This issue needs a description. What is t

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
chn5944 commented on PR #25739: URL: https://github.com/apache/flink/pull/25739#issuecomment-2518020325 > > @fsk119 i already report this issue by e-mail and get response from [fskm...@gmail.com](mailto:fskm...@gmail.com) > > @chn5944 I am curious what the email exchange was and wheth

Re: [PR] [FLINK-36625] add lineage helper class for connector integration [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25712: URL: https://github.com/apache/flink/pull/25712#discussion_r1869612910 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/TypeDatasetFacetProvider.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwar

[jira] [Assigned] (FLINK-35241) Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-35241: --- Assignee: Hanyu Zheng > Support SQL FLOOR and CEIL functions with SECOND and MINUTE

[jira] [Commented] (FLINK-36840) Multiple time-related built-in functions cannot be called

2024-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902989#comment-17902989 ] Sergey Nuyanzin commented on FLINK-36840: - Merged as [134a9e6fc30cf34b09f09ef6c

Re: [PR] [FLINK-36066][runtime] Introducing the AdaptiveGraphManager component [flink]

2024-12-04 Thread via GitHub
zhuzhurk commented on code in PR #25414: URL: https://github.com/apache/flink/pull/25414#discussion_r1869800542 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -1678,10 +1678,27 @@ public static ResultPartitionType dete

[jira] [Commented] (FLINK-36663) [Window]The first processWatermark() after Sliding Window restore may have extra expired data.

2024-12-04 Thread Thomas Cooper (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903051#comment-17903051 ] Thomas Cooper commented on FLINK-36663: --- Instead of pasting screen shots could you

Re: [PR] [FLINK-36664][Window]Window with offset need deal offset when cal nextTriggerWatermark. [flink]

2024-12-04 Thread via GitHub
tomncooper commented on code in PR #25629: URL: https://github.com/apache/flink/pull/25629#discussion_r1869901227 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/slicing/SliceAssigners.java: ## @@ -566,6 +592,11 @@ public long

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
davidradl commented on PR #25739: URL: https://github.com/apache/flink/pull/25739#issuecomment-2517947100 > @fsk119 i already report this issue by e-mail and get response from [fskm...@gmail.com](mailto:fskm...@gmail.com) @chn5944 I am curious what the email exchange was and whether i

Re: [PR] [FLINK-36679][runtime] Add a metric to track checkpoint _metadata size [flink]

2024-12-04 Thread via GitHub
tomncooper commented on code in PR #25634: URL: https://github.com/apache/flink/pull/25634#discussion_r1869868269 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java: ## @@ -93,6 +93,11 @@ public abstract class AbstractCheckpointStats

[jira] [Commented] (FLINK-36664) [Window]The window with window_offset will lose data.

2024-12-04 Thread Thomas Cooper (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903042#comment-17903042 ] Thomas Cooper commented on FLINK-36664: --- Instead of pasting screen shots could you

Re: [PR] Update maxwell.md [flink]

2024-12-04 Thread via GitHub
davidradl commented on PR #25721: URL: https://github.com/apache/flink/pull/25721#issuecomment-2517832533 Please ad [HOTFIX] to the Jira title as per the process. Also the CI is failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Update flink-architecture.md [flink]

2024-12-04 Thread via GitHub
davidradl commented on PR #25720: URL: https://github.com/apache/flink/pull/25720#issuecomment-2517829505 @harikamisetty please add [HOTFIX] to the Jira title as per the process -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-36825][table] Introduce FastTop1Function in Rank with Async State API [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25717: URL: https://github.com/apache/flink/pull/25717#discussion_r1869737400 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/FastTop1Function.java: ## @@ -30,38 +30,28 @@ import org.apache.flink.

Re: [PR] [FLINK-36825][table] Introduce FastTop1Function in Rank with Async State API [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25717: URL: https://github.com/apache/flink/pull/25717#discussion_r1869709030 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/asyncprocessing/AbstractAsyncSyncStateTopNFunction.java: ## @@ -0,0 +1,

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
chn5944 commented on code in PR #25739: URL: https://github.com/apache/flink/pull/25739#discussion_r1869702019 ## flink-dist/src/main/flink-bin/bin/bash-java-utils.sh: ## @@ -25,11 +34,41 @@ readFromConfigFile() { # first extract the value with the given key (1st sed), then

Re: [PR] [FLINK-36809][table] Add correct call syntax for functions without () [flink]

2024-12-04 Thread via GitHub
snuyanzin commented on PR #25733: URL: https://github.com/apache/flink/pull/25733#issuecomment-2517230334 hm, one last comment I noticed that this PR both in name and commit message refers to FLINK-36809 which is in fact a different issue IIUC the correct issue should be FLINK-36840

Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without () [flink]

2024-12-04 Thread via GitHub
dawidwys commented on PR #25733: URL: https://github.com/apache/flink/pull/25733#issuecomment-2517423038 +1 post factum, I've been checking if that covers all the functions. The parentheses-less handling in Flink is messy. Theoretically Calcite does not allow calling functions

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25739: URL: https://github.com/apache/flink/pull/25739#discussion_r1869670605 ## flink-dist/src/main/flink-bin/bin/bash-java-utils.sh: ## @@ -25,11 +34,41 @@ readFromConfigFile() { # first extract the value with the given key (1st sed), th

Re: [PR] [FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2024-12-04 Thread via GitHub
MartijnVisser commented on PR #25713: URL: https://github.com/apache/flink/pull/25713#issuecomment-2517607355 TBF, the failure does seem unrelated to this PR. Maybe it's a flaky test (which still needs to be solved, but not necessarily within this PR) -- This is an automated message from

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25739: URL: https://github.com/apache/flink/pull/25739#discussion_r1869672924 ## flink-dist/src/main/flink-bin/bin/bash-java-utils.sh: ## @@ -25,11 +34,41 @@ readFromConfigFile() { # first extract the value with the given key (1st sed), th

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25739: URL: https://github.com/apache/flink/pull/25739#discussion_r1869668612 ## flink-dist/src/main/flink-bin/bin/bash-java-utils.sh: ## @@ -25,11 +34,41 @@ readFromConfigFile() { # first extract the value with the given key (1st sed), th

Re: [PR] [WIP] Introduce generalized watermarks [flink]

2024-12-04 Thread via GitHub
codenohup closed pull request #25726: [WIP] Introduce generalized watermarks URL: https://github.com/apache/flink/pull/25726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without () [flink]

2024-12-04 Thread via GitHub
snuyanzin merged PR #25733: URL: https://github.com/apache/flink/pull/25733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25714: URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161 ## pom.xml: ## @@ -177,7 +177,7 @@ under the License. 10.18.2 Review Comment: can we remove this comment and the line below now w

Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25714: URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161 ## pom.xml: ## @@ -177,7 +177,7 @@ under the License. 10.18.2 Review Comment: can we remove this comment now we are 2.38+ . Is th

Re: [PR] [FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2024-12-04 Thread via GitHub
mehdid93 commented on PR #25718: URL: https://github.com/apache/flink/pull/25718#issuecomment-2517616872 @MartijnVisser I've raised this PR for upgrading dependencies to solve critical/high severities in case you may not have the notification -- This is an automated message from the Apach

Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25714: URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161 ## pom.xml: ## @@ -177,7 +177,7 @@ under the License. 10.18.2 Review Comment: can we remove this comment now we are 2.38+ . Is th

Re: [PR] [FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2024-12-04 Thread via GitHub
MartijnVisser commented on PR #25713: URL: https://github.com/apache/flink/pull/25713#issuecomment-2517607633 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]

2024-12-04 Thread via GitHub
davidradl commented on code in PR #25714: URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161 ## pom.xml: ## @@ -177,7 +177,7 @@ under the License. 10.18.2 Review Comment: can we remove this comment and potentially the line

Re: [PR] Flink 33387 33388 draft2 for CI [flink]

2024-12-04 Thread via GitHub
RocMarshal commented on PR #25734: URL: https://github.com/apache/flink/pull/25734#issuecomment-2517521053 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

  1   2   >