umeshdangat commented on PR #3434: URL: https://github.com/apache/flink-cdc/pull/3434#issuecomment-2518863198
> I guess that some classes refer to Flink like [BinaryArrayData](https://github.com/apache/flink/blob/b48ccce1ce201ea76e11f089f43e8c115b96a992/flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java#L52) , so I think that we should avoid adding unnecessary change and add enough tests. The reason to not reuse [BinaryArrayData](https://github.com/apache/flink/blob/b48ccce1ce201ea76e11f089f43e8c115b96a992/flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java#L52) from flink source code is that flink-cdc appears to have its own interface defined for [ArrayData](https://github.com/apache/flink-cdc/blob/master/flink-cdc-common/src/main/java/org/apache/flink/cdc/common/data/ArrayData.java#L42) which is then used in [RecordData](https://github.com/apache/flink-cdc/blob/master/flink-cdc-common/src/main/java/org/apache/flink/cdc/common/data/RecordData.java#L154). RecordData in flink-cdc essentially a port of [RowData](https://github.com/apache/flink/blob/b48ccce1ce201ea76e11f089f43e8c115b96a992/flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/RowData.java#L192) interface from flink. Also there are existing re-implementations of flink classes like GenericArrayData in flink-cdc. So there is prior art to this pattern as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
