liuml07 commented on code in PR #25634: URL: https://github.com/apache/flink/pull/25634#discussion_r1870664148
########## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java: ########## @@ -93,6 +93,11 @@ public abstract class AbstractCheckpointStats implements Serializable { */ public abstract long getCheckpointedSize(); + /** @return The metadata file size, 0 if unknown. */ + public long getMetadataSize() { + return 0; Review Comment: Right, neither `PendingCheckpointStats` nor `FailedCheckpointStats` has this value defined. I agree it's clearer to keep it here as abstracted and let `PendingCheckpointStats` implement it (which `FailedCheckpointStats` will inherit). I'm also wondering if we do put this in the abstract class at all, and just expose in the `CompletedCheckpointStats`. Let me check this again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org