snuyanzin commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1870394479


##########
pom.xml:
##########
@@ -177,7 +177,7 @@ under the License.
                <checkstyle.version>10.18.2</checkstyle.version>
                <!-- can be removed with maven-spotless-plugin:2.38+ -->

Review Comment:
   removed.
   >can we remove this comment now we are 2.38+ . Is there anything to action? 
I assume we can still skip spotless at 2.38+. Otherwise we should add this asap 
to minimize merge issues for open PRs.
   
   Didn't get your comment.
   The reason it was skipped for lower than 2.38 is the fact that spotless with 
those version didn't support java 21.
   Regarding merge issues: I wouldn't expect lots of conflicts since changes 
are related to some weird situations (you can find them in changeset)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to