tomncooper commented on code in PR #25629: URL: https://github.com/apache/flink/pull/25629#discussion_r1869901227
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/slicing/SliceAssigners.java: ########## @@ -566,6 +592,11 @@ public long getSliceEndInterval() { return innerAssigner.getSliceEndInterval(); } + @Override + public long getWindowOffset() { + return 0; Review Comment: If this class is abstract then you don't need to return anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org