dawidwys commented on PR #25733: URL: https://github.com/apache/flink/pull/25733#issuecomment-2517423038
+1 post factum, I've been checking if that covers all the functions. The parentheses-less handling in Flink is messy. Theoretically Calcite does not allow calling functions with `SqlSyntax.FUNCTION_ID` with parentheses. That should include: PI, CURRENT_DATE, MATCH_ROWTIME, MATCH_PROCTIME, CURRENT_CATALOG, ... However we override some of the above in `FlinkSqlOperatorTable` with `SqlSyntax.FUNCTION`, but some we don't override them and the original Calicite's are used. The PR should make the table API work with the current state of the engine, but we should figure out where do those discrepancies come from and decide what we want to do for those functions in the long run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
